Re: [Tarantool-patches] [PATCH v2 luajit 0/6] Unified extension for debuggers

[Evgeniy Temirgaleev via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 2283 bytes --]

Hi, Sergey, thanks for the patch!

The 2..6 commits are LGTM.
--
Best regards,
Evgeniy Temirgaleev

> 
> From: Sergey Kaplun <skaplun@tarantool.org>
> To: Mikhail Elhimov <m.elhimov@vk.team>, Sergey Bronnikov <sergeyb@tarantool.org
> >, Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
> Cc: tarantool-patches@dev.tarantool.org, Sergey Kaplun <skaplun@tarantool.org
> >
> Date: Tuesday, May 19, 2026 3:39 PM +03:00
> This patchset adds tests for LLDB and GDB debugger extensions via the
> first commit. The next two commits refactor the LLDB extension and sort
> initialized commands alphabetically. The fourth commit adds the
> lightuserdata support for LJ_64 for LLDB too. The next commit joins
> extension logic into the single file, making the LuaJIT-related code
> debugger-agnostic. The last commit adds the CI workflow for arm64 and
> x86_64 architectures.
> 
> Branch: https://github.com/tarantool/luajit/tree/skaplun/unified-debugger
> 
> Changes in the v2:
> Moved squashed part of the refactoring from the third commit to the
> second one.
> 
> Maksim Kokryashkin (1):
> test: introduce tests for debugging extensions
> 
> Sergey Kaplun (5):
> lldb: refactor extension
> dbg: sort initialization of commands
> lldb: support full-range 64-bit lightuserdata
> dbg: generalize extension
> ci: introduce workflow to test debugger extension
> 
> .flake8rc | 5 -
> .github/actions/setup-debuggers/README.md | 13 +
> .github/actions/setup-debuggers/action.yml | 12 +
> .github/workflows/debuggers.yml | 61 +
> src/luajit-gdb.py | 884 ------------
> src/luajit_dbg.py | 1281 +++++++++++++++++
> src/luajit_lldb.py | 1124 ---------------
> test/CMakeLists.txt | 7 +
> test/tarantool-debugger-tests/CMakeLists.txt | 93 ++
> .../debug-extension-tests.py | 292 ++++
> 10 files changed, 1759 insertions(+), 2013 deletions(-)
> create mode 100644 .github/actions/setup-debuggers/README.md
> create mode 100644 .github/actions/setup-debuggers/action.yml
> create mode 100644 .github/workflows/debuggers.yml
> delete mode 100644 src/luajit-gdb.py
> create mode 100644 src/luajit_dbg.py
> delete mode 100644 src/luajit_lldb.py
> create mode 100644 test/tarantool-debugger-tests/CMakeLists.txt
> create mode 100644 test/tarantool-debugger-tests/debug-extension-tests.py
> 
> --
> 2.53.0
>

[-- Attachment #2: Type: text/html, Size: 3252 bytes --]