Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

Thanks for your review!

On 03.10.22, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch!
> LGTM, except a single nit below.

Added your tag:
| Reviewed-by: Sergey Kaplun <skaplun@tarantool.org>

> 
> Also, I suppose that the test will be added in the Tarantool patch with
> version bump, as far as this option will be enabled by default for
> Tarantool build.
> Am I right?

Partially. Honestly, I didn't plan to add the test at all (since we
don't write tests for the build options). However, if you insist, I'll
add one in scope of the PR enabling this option in 2.11 (NB: it will be
different PR than the one bumping LuaJIT submodule).

> 
> On 02.10.22, Igor Munkin wrote:
> > Originally there is nether a special option nor a variable to configure
> > check for instrunction/line hooks for compiled code via the build system
> 
> Typo: s/check/the check/

Fixed, thanks!

> 
> > being used. We finally decided to use this feature in Tarantool, so for
> > convenient managing LUAJIT_ENABLE_CHECKHOOK option is added to the root
> > project CMakeLists.txt.
> > 
> > Needed for tarantool/tarantool#7762
> > 
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > ---
> > 
> > Issue: https://github.com/tarantool/tarantool/issues/7762
> > Branch: https://github.com/tarantool/luajit/tree/imun/luajit-enable-checkhook
> > CI: https://github.com/tarantool/luajit/commit/701de8c
> > 
> >  CMakeLists.txt | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/CMakeLists.txt b/CMakeLists.txt
> > index 8b49f9d7..c870cce2 100644
> > --- a/CMakeLists.txt
> > +++ b/CMakeLists.txt
> 
> <snipped>
> 
> > -- 
> > 2.34.0
> > 
> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM