Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>,
	Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option
Date: Fri, 11 Nov 2022 11:54:50 +0300	[thread overview]
Message-ID: <Y24N2pmi+s49edTN@tarantool.org> (raw)
In-Reply-To: <701de8c1cd6ee15f42062c1d07dc133834bab5db.1664723361.git.imun@tarantool.org>

I've checked the patch into all long-term branches in tarantool/luajit
and bumped a new version in master, 2.10 and 1.10.

On 02.10.22, Igor Munkin wrote:
> Originally there is nether a special option nor a variable to configure
> check for instrunction/line hooks for compiled code via the build system
> being used. We finally decided to use this feature in Tarantool, so for
> convenient managing LUAJIT_ENABLE_CHECKHOOK option is added to the root
> project CMakeLists.txt.
> 
> Needed for tarantool/tarantool#7762
> 
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> 
> Issue: https://github.com/tarantool/tarantool/issues/7762
> Branch: https://github.com/tarantool/luajit/tree/imun/luajit-enable-checkhook
> CI: https://github.com/tarantool/luajit/commit/701de8c
> 
>  CMakeLists.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 8b49f9d7..c870cce2 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -180,6 +180,11 @@ if(LUAJIT_ENABLE_GC64)
>    AppendFlags(TARGET_C_FLAGS -DLUAJIT_ENABLE_GC64)
>  endif()
>  
> +option(LUAJIT_ENABLE_CHECKHOOK "Check instruction/line hooks for compiled code" OFF)
> +if(LUAJIT_ENABLE_CHECKHOOK)
> +  AppendFlags(TARGET_C_FLAGS -DLUAJIT_ENABLE_CHECKHOOK)
> +endif()
> +
>  # Disable memory profiler.
>  option(LUAJIT_DISABLE_MEMPROF "LuaJIT memory profiler support" OFF)
>  if(LUAJIT_DISABLE_MEMPROF)
> -- 
> 2.34.0
> 

-- 
Best regards,
IM

      parent reply	other threads:[~2022-11-11  9:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02 15:10 Igor Munkin via Tarantool-patches
2022-10-03  2:24 ` Sergey Kaplun via Tarantool-patches
2022-10-04 16:05   ` Igor Munkin via Tarantool-patches
2022-10-03 10:57 ` Maxim Kokryashkin via Tarantool-patches
2022-10-04 16:05   ` Igor Munkin via Tarantool-patches
2022-11-11  8:54 ` Igor Munkin via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y24N2pmi+s49edTN@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox