Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option
Date: Mon, 3 Oct 2022 05:24:17 +0300	[thread overview]
Message-ID: <YzpH0f4I5Atmaa+r@root> (raw)
In-Reply-To: <701de8c1cd6ee15f42062c1d07dc133834bab5db.1664723361.git.imun@tarantool.org>

Hi, Igor!

Thanks for the patch!
LGTM, except a single nit below.

Also, I suppose that the test will be added in the Tarantool patch with
version bump, as far as this option will be enabled by default for
Tarantool build.
Am I right?

On 02.10.22, Igor Munkin wrote:
> Originally there is nether a special option nor a variable to configure
> check for instrunction/line hooks for compiled code via the build system

Typo: s/check/the check/

> being used. We finally decided to use this feature in Tarantool, so for
> convenient managing LUAJIT_ENABLE_CHECKHOOK option is added to the root
> project CMakeLists.txt.
> Needed for tarantool/tarantool#7762
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> Issue: https://github.com/tarantool/tarantool/issues/7762
> Branch: https://github.com/tarantool/luajit/tree/imun/luajit-enable-checkhook
> CI: https://github.com/tarantool/luajit/commit/701de8c
>  CMakeLists.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> diff --git a/CMakeLists.txt b/CMakeLists.txt
> index 8b49f9d7..c870cce2 100644
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt


> -- 
> 2.34.0

Best regards,
Sergey Kaplun

  reply	other threads:[~2022-10-03  2:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02 15:10 Igor Munkin via Tarantool-patches
2022-10-03  2:24 ` Sergey Kaplun via Tarantool-patches [this message]
2022-10-04 16:05   ` Igor Munkin via Tarantool-patches
2022-10-03 10:57 ` Maxim Kokryashkin via Tarantool-patches
2022-10-04 16:05   ` Igor Munkin via Tarantool-patches
2022-11-11  8:54 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzpH0f4I5Atmaa+r@root \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option' \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox