Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option
Date: Tue, 4 Oct 2022 19:05:36 +0300	[thread overview]
Message-ID: <YzxZ0LcVI8H9sLFl@tarantool.org> (raw)
In-Reply-To: <1664794656.218847909@f526.i.mail.ru>

Max,

Thanks for your review!

On 03.10.22, Maxim Kokryashkin wrote:
> 
> Hi, Igor!
> Thanks for the patch!
> LGTM, except for the nits, Sergey have already mentioned.

Added your tag:
| Reviewed-by: Maxim Kokryashkin <m.kokryashkin@tarantool.org>

> --
> Best regards,
> Maxim Kokryashkin

<snipped>

-- 
Best regards,
IM

  reply	other threads:[~2022-10-04 16:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-02 15:10 Igor Munkin via Tarantool-patches
2022-10-03  2:24 ` Sergey Kaplun via Tarantool-patches
2022-10-04 16:05   ` Igor Munkin via Tarantool-patches
2022-10-03 10:57 ` Maxim Kokryashkin via Tarantool-patches
2022-10-04 16:05   ` Igor Munkin via Tarantool-patches [this message]
2022-11-11  8:54 ` Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzxZ0LcVI8H9sLFl@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox