Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option

[Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]


Hi, Igor!
Thanks for the patch!
LGTM, except for the nits, Sergey have already mentioned.
--
Best regards,
Maxim Kokryashkin
 
  
>Воскресенье, 2 октября 2022, 18:21 +03:00 от Igor Munkin <imun@tarantool.org>:
> 
>Originally there is nether a special option nor a variable to configure
>check for instrunction/line hooks for compiled code via the build system
>being used. We finally decided to use this feature in Tarantool, so for
>convenient managing LUAJIT_ENABLE_CHECKHOOK option is added to the root
>project CMakeLists.txt.
>
>Needed for tarantool/tarantool#7762
>
>Signed-off-by: Igor Munkin < imun@tarantool.org >
>---
>
>Issue:  https://github.com/tarantool/tarantool/issues/7762
>Branch:  https://github.com/tarantool/luajit/tree/imun/luajit-enable-checkhook
>CI:  https://github.com/tarantool/luajit/commit/701de8c
>
> CMakeLists.txt | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/CMakeLists.txt b/CMakeLists.txt
>index 8b49f9d7..c870cce2 100644
>--- a/CMakeLists.txt
>+++ b/CMakeLists.txt
>@@ -180,6 +180,11 @@ if(LUAJIT_ENABLE_GC64)
>   AppendFlags(TARGET_C_FLAGS -DLUAJIT_ENABLE_GC64)
> endif()
> 
>+option(LUAJIT_ENABLE_CHECKHOOK "Check instruction/line hooks for compiled code" OFF)
>+if(LUAJIT_ENABLE_CHECKHOOK)
>+ AppendFlags(TARGET_C_FLAGS -DLUAJIT_ENABLE_CHECKHOOK)
>+endif()
>+
> # Disable memory profiler.
> option(LUAJIT_DISABLE_MEMPROF "LuaJIT memory profiler support" OFF)
> if(LUAJIT_DISABLE_MEMPROF)
>--
>2.34.0
 

[-- Attachment #2: Type: text/html, Size: 2361 bytes --]