From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 53F286F3C8; Mon, 3 Oct 2022 05:27:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 53F286F3C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1664764032; bh=HIVjLp0roBwKQkm7oiyGnvfeE87hoK8aSNf7SEaUiHs=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=TAt1DWpltQbOcG9yObD+eIPSLwBew0dj4Jv5/XNZUe8mY+h4g/P3oNelFkAmDqfR+ K5d5ZPawemGqMRQdPsPzkSzxIOP5Leg/E8D3LAHQrxrWR+QQPp8LoYLRqs3H7tnp8T AK//DxjrslE3AfHhQ0sE+Jn47sRunhLswo3kkicI= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 051B96F3C8 for ; Mon, 3 Oct 2022 05:27:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 051B96F3C8 Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1ofBAj-0005bj-6M; Mon, 03 Oct 2022 05:27:09 +0300 Date: Mon, 3 Oct 2022 05:24:17 +0300 To: Igor Munkin Message-ID: References: <701de8c1cd6ee15f42062c1d07dc133834bab5db.1664723361.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <701de8c1cd6ee15f42062c1d07dc133834bab5db.1664723361.git.imun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD95BC634034C2E79655B374CAF81AF41E71EC8413721E9F777182A05F5380850406B465E2B7F6B956C5F4E0EA32E97A899716120339E475C69A5D7981818872E50 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76C0A440987CA342DC2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE73F300A97FDD4E158EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B8859CA687ABA27BAFB5B9780357ABC94EAE32797BB756F11CC7F00164DA146DAFE8445B8C89999728AA50765F790063765560A57B79E3C14389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC886A7C529F68B8E5CF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C376D42398B842EAE6E0066C2D8992A164AD6D5ED66289B52698AB9A7B718F8C46E0066C2D8992A16725E5C173C3A84C375AB9F4AF0B63FD1BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFE478A468B35FE7671DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C30584FF81F342DA0735872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E142185AC9E3593CE4B31AB1881A6453793CE9274300E5CE05BD4401A9E91200F654B0CBAED148C0C85B120E0E6A89656E61D30D17BF47526BFB2414E4F428491B595A9C2B6934AE262D3EE7EAB7254005DCED8DA55E71E02F9FC08E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34431D0341F6B74DD320E6AD95B2566D57A91DEEB3D12747FC328F6A0CF766FB6AB089546E3C09A80A1D7E09C32AA3244C1D8B50A597325A6550F8E1385DDA8957853296C06374E602FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojf/9mtrlthuS6ay/F0e1Azg== X-Mailru-Sender: 11ABF2DAD5F2676891056722DE4A719E5FE961890DCA7ACA5F4E0EA32E97A899009DB4CE3002C7DBDEDBA653FF35249392D99EB8CC7091A70E183A470755BFD208F19895AA18418972D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM, except a single nit below. Also, I suppose that the test will be added in the Tarantool patch with version bump, as far as this option will be enabled by default for Tarantool build. Am I right? On 02.10.22, Igor Munkin wrote: > Originally there is nether a special option nor a variable to configure > check for instrunction/line hooks for compiled code via the build system Typo: s/check/the check/ > being used. We finally decided to use this feature in Tarantool, so for > convenient managing LUAJIT_ENABLE_CHECKHOOK option is added to the root > project CMakeLists.txt. > > Needed for tarantool/tarantool#7762 > > Signed-off-by: Igor Munkin > --- > > Issue: https://github.com/tarantool/tarantool/issues/7762 > Branch: https://github.com/tarantool/luajit/tree/imun/luajit-enable-checkhook > CI: https://github.com/tarantool/luajit/commit/701de8c > > CMakeLists.txt | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/CMakeLists.txt b/CMakeLists.txt > index 8b49f9d7..c870cce2 100644 > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > -- > 2.34.0 > -- Best regards, Sergey Kaplun