From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 268796F3C8; Tue, 4 Oct 2022 19:15:51 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 268796F3C8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1664900151; bh=2NYfi3Ixqenw/O98nXe0TIyuUQ7DdFey9EFr7RdAO6Y=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=LE2X5UtjUf+smWSpxi/4y+L9KHs1ATe1XpGDf7WMHOkS2ZWUcRZKOshCcTmYtBXgA iqE4AuU9aoO3IK+zUF4brzXmxfhsdL7EjDxQTrtXCrfwgnL2dkM7ZsLOyz8G2ToAyc RgGRxbdfju3AB5nL0y+ItAE6JX162RrjZ+NhlvVo= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 994956F3C8 for ; Tue, 4 Oct 2022 19:15:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 994956F3C8 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1ofkaB-0005Y9-HJ; Tue, 04 Oct 2022 19:15:47 +0300 Date: Tue, 4 Oct 2022 19:05:22 +0300 To: Sergey Kaplun Message-ID: References: <701de8c1cd6ee15f42062c1d07dc133834bab5db.1664723361.git.imun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD90D1D1AB5450899812CC5C4D6F623EB9ED8850DDB689FED71182A05F5380850404C228DA9ACA6FE279B6CCBCCACC384D3D4993E67151687F8E9BED6BE1004C7F144D531C2042F2958 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7624C4D757C4F5837EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006374F960C921106F05B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8222B6A8DC8C503E6051C4C2293E066B0117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCE287FC2BA681BAD5A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C088D2E8BEBF93D4B068655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C0E67A00557831CF643847C11F186F3C59DAA53EE0834AAEE X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34728AF701C68E4539D8C345BBEBC8BE3706F099AA2E0CEBB0EA201D88112002082F410820AAB0DAEE1D7E09C32AA3244C1DC3EECEE78010405D1687B327830258B4DF56057A86259F927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtuniG44heXLJQfGgKPOT1g== X-DA7885C5: 78320FD0C019F4D8FD7E7F54CE52554994A2E0B2E4C82C2EABF31185E843AD75262E2D401490A4A0DB037EFA58388B346E8BC1A9835FDE71 X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E778DC62375B5E5E375AB36E1A496489BA7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] build: introduce LUAJIT_ENABLE_CHECKHOOK option X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 03.10.22, Sergey Kaplun wrote: > Hi, Igor! > > Thanks for the patch! > LGTM, except a single nit below. Added your tag: | Reviewed-by: Sergey Kaplun > > Also, I suppose that the test will be added in the Tarantool patch with > version bump, as far as this option will be enabled by default for > Tarantool build. > Am I right? Partially. Honestly, I didn't plan to add the test at all (since we don't write tests for the build options). However, if you insist, I'll add one in scope of the PR enabling this option in 2.11 (NB: it will be different PR than the one bumping LuaJIT submodule). > > On 02.10.22, Igor Munkin wrote: > > Originally there is nether a special option nor a variable to configure > > check for instrunction/line hooks for compiled code via the build system > > Typo: s/check/the check/ Fixed, thanks! > > > being used. We finally decided to use this feature in Tarantool, so for > > convenient managing LUAJIT_ENABLE_CHECKHOOK option is added to the root > > project CMakeLists.txt. > > > > Needed for tarantool/tarantool#7762 > > > > Signed-off-by: Igor Munkin > > --- > > > > Issue: https://github.com/tarantool/tarantool/issues/7762 > > Branch: https://github.com/tarantool/luajit/tree/imun/luajit-enable-checkhook > > CI: https://github.com/tarantool/luajit/commit/701de8c > > > > CMakeLists.txt | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/CMakeLists.txt b/CMakeLists.txt > > index 8b49f9d7..c870cce2 100644 > > --- a/CMakeLists.txt > > +++ b/CMakeLists.txt > > > > > -- > > 2.34.0 > > > > -- > Best regards, > Sergey Kaplun -- Best regards, IM