From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Igor Munkin <imun@tarantool.org>, Maxim Kokryashkin <m.kokryashkin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 14/15] test: fix E741 errors by pycodestyle Date: Thu, 3 Aug 2023 17:34:05 +0300 [thread overview] Message-ID: <7ee3c59c-905e-d29b-b6e4-b6ef682afbb0@tarantool.org> (raw) In-Reply-To: <c87e7307fc05301b5e286427f62f9f0e3152bce4.1691047132.git.imun@tarantool.org> Hi, Igor thanks for the patch! On 8/3/23 10:30, Igor Munkin wrote: > Fixed 3 occurrences of E741 ("ambiguous variable name 'l'") error > reported by pycodestyle[1]. > > [1]: https://www.flake8rules.com/rules/E741.html > > Signed-off-by: Igor Munkin <imun@tarantool.org> > --- > src/luajit-gdb.py | 6 +++--- > src/luajit_lldb.py | 12 ++++++------ > 2 files changed, 9 insertions(+), 9 deletions(-) > > diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py > index a0c8f24e..2e0b145b 100644 > --- a/src/luajit-gdb.py > +++ b/src/luajit-gdb.py > @@ -233,15 +233,15 @@ def L(L=None): > # lookup a symbol for the main coroutine considering the host app > # XXX Fragile: though the loop initialization looks like a crap but it > # respects both Python 2 and Python 3. > - for l in [L] + list(map(lambda l: lookup(l), ( > + for coroutine in [L] + list(map(lambda main: lookup(main), ( it is not obvious why variable "l" was replaced by "coroutine". Could you elaborate? The same below > # LuaJIT main coro (see luajit/src/luajit.c) > 'globalL', > # Tarantool main coro (see tarantool/src/lua/init.h) > 'tarantool_L', > # TODO: Add more > ))): > - if l: > - return cast('lua_State *', l) > + if coroutine: > + return cast('lua_State *', coroutine) > > > def G(L): > diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py > index 4787c62c..76fb3141 100644 > --- a/src/luajit_lldb.py > +++ b/src/luajit_lldb.py > @@ -453,15 +453,15 @@ def L(L=None): > # lookup a symbol for the main coroutine considering the host app > # XXX Fragile: though the loop initialization looks like a crap but it > # respects both Python 2 and Python 3. > - for l in [L] + list(map(lambda l: lookup_global(l), ( > + for coroutine in [L] + list(map(lambda main: lookup_global(main), ( > # LuaJIT main coro (see luajit/src/luajit.c) > 'globalL', > # Tarantool main coro (see tarantool/src/lua/init.h) > 'tarantool_L', > # TODO: Add more > ))): > - if l: > - return lua_State(l) > + if coroutine: > + return lua_State(coroutine) > > > def tou32(val): > @@ -1066,9 +1066,9 @@ coroutine guest stack: > If L is ommited the main coroutine is used. > ''' > def execute(self, debugger, args, result): > - l = self.parse(args) > - l_ptr = cast('lua_State *', l) if l is not None else None > - print('{}'.format(dump_stack(L(l_ptr)))) > + coro = self.parse(args) > + coro_ptr = cast('lua_State *', coro) if coro is not None else None > + print('{}'.format(dump_stack(L(coro_ptr)))) > > > def register_commands(debugger, commands):
next prev parent reply other threads:[~2023-08-03 14:34 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-03 7:30 [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 01/15] test: fix E122 errors by pycodestyle Igor Munkin via Tarantool-patches 2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:49 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 02/15] test: fix E128 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:52 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 03/15] test: fix E201 and E202 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:53 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 04/15] test: fix E203 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 05/15] test: fix E231 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 06/15] test: fix E251 " Igor Munkin via Tarantool-patches 2023-08-03 14:27 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:58 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 07/15] test: fix E301 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:01 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 08/15] test: fix E302 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:02 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 09/15] test: fix E303 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:03 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 10/15] test: fix E305 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:05 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 11/15] test: fix E502 " Igor Munkin via Tarantool-patches 2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 12/15] test: fix E711 " Igor Munkin via Tarantool-patches 2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 13/15] test: fix E722 " Igor Munkin via Tarantool-patches 2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:10 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 14/15] test: fix E741 " Igor Munkin via Tarantool-patches 2023-08-03 14:34 ` Sergey Bronnikov via Tarantool-patches [this message] 2023-08-07 11:00 ` Igor Munkin via Tarantool-patches 2023-08-07 13:45 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:15 ` Maxim Kokryashkin via Tarantool-patches 2023-08-07 10:57 ` Igor Munkin via Tarantool-patches 2023-08-13 20:25 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Igor Munkin via Tarantool-patches 2023-08-03 14:23 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches 2023-08-07 13:35 ` Igor Munkin via Tarantool-patches 2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 16/15] gdb: fix Python <assert> statement usage Igor Munkin via Tarantool-patches 2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-13 20:24 ` Maxim Kokryashkin via Tarantool-patches 2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 17/15] test: fix E275 errors by pycodestyle Igor Munkin via Tarantool-patches 2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-13 19:25 ` Maxim Kokryashkin via Tarantool-patches 2023-08-08 8:18 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Sergey Bronnikov via Tarantool-patches 2023-08-07 12:17 ` Igor Munkin via Tarantool-patches 2023-08-07 13:48 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 21:02 ` Maxim Kokryashkin via Tarantool-patches 2023-08-08 19:29 ` Igor Munkin via Tarantool-patches 2023-08-08 19:42 ` [Tarantool-patches] [PATCH luajit 18/15] test: suppress E131 errors by pycodestyle Igor Munkin via Tarantool-patches 2023-08-13 13:52 ` Maxim Kokryashkin via Tarantool-patches 2023-08-08 19:42 ` [Tarantool-patches] [PATCH luajit 19/15] test: fix E501 " Igor Munkin via Tarantool-patches 2023-08-13 13:55 ` Maxim Kokryashkin via Tarantool-patches 2023-08-14 7:28 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Maxim Kokryashkin via Tarantool-patches 2023-08-21 11:05 ` [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7ee3c59c-905e-d29b-b6e4-b6ef682afbb0@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 14/15] test: fix E741 errors by pycodestyle' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox