From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Igor Munkin <imun@tarantool.org>, Maxim Kokryashkin <m.kokryashkin@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Date: Thu, 3 Aug 2023 17:23:28 +0300 [thread overview] Message-ID: <2f20f91c-1336-b34b-6681-3947e96b486d@tarantool.org> (raw) In-Reply-To: <df9a545109279a9eb40856933b17d7107d6eacaa.1691047132.git.imun@tarantool.org> [-- Attachment #1: Type: text/plain, Size: 4135 bytes --] Hi, Igor thanks for the patch! see my comments Sergey On 8/3/23 10:30, Igor Munkin wrote: > This patch introduces a separate target to run flake8 against all Python > scripts within LuaJIT repository (i.e. debugger extensions). There are > some tweaks in .flake8rc regarding our style: one can find more info in > the config file. > > The new target is a dependency for the new <LuaJIT-lint> target, that > joins both luacheck and flake8 linter runs. CI job with linters is > adjusted respectively. > > Signed-off-by: Igor Munkin<imun@tarantool.org> > --- > .flake8rc | 12 ++++++++++++ > .github/workflows/lint.yml | 4 ++-- > test/CMakeLists.txt | 28 ++++++++++++++++++++++++++++ > 3 files changed, 42 insertions(+), 2 deletions(-) > create mode 100644 .flake8rc > > diff --git a/.flake8rc b/.flake8rc > new file mode 100644 > index 00000000..b6f7ad48 > --- /dev/null > +++ b/.flake8rc > @@ -0,0 +1,12 @@ > +[flake8] > +extend-ignore = > + # TODO: I have no idea, how to fix this. flake8 suggests nothing > + # (like clang-format or checkpatch.pl do). Help needed. > + E131, > + # TODO: I have no idea, how to fix this. flake8 suggests nothing > + # (like clang-format or checkpatch.pl do). Help needed. > + E501, > + # XXX: Suppress F821, since we have autogenerated names for > + # 'ptr' type complements in luajit_lldb.py. > + F821 > +max-line-length = 80 > diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml > index 70c98104..6b420f68 100644 > --- a/.github/workflows/lint.yml > +++ b/.github/workflows/lint.yml > @@ -41,7 +41,7 @@ jobs: > run: | > # TODO: Move this step to a separate action. > sudo apt -y update > - sudo apt -y install cmake ninja-build lua5.1 luarocks > + sudo apt -y install cmake ninja-build lua5.1 luarocks flake8 > sudo luarocks install luacheck > # Set CMAKE_BUILD_PARALLEL_LEVEL environment variable to > # limit the number of parallel jobs for build/test step. > @@ -49,5 +49,5 @@ jobs: > - name: configure > run: cmake -S . -B ${{ env.BUILDDIR }} -G Ninja > - name: test > - run: cmake --build . --target LuaJIT-luacheck > + run: cmake --build . --target LuaJIT-lint > working-directory: ${{ env.BUILDDIR }} > diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt > index 47296a22..17ac5cac 100644 > --- a/test/CMakeLists.txt > +++ b/test/CMakeLists.txt > @@ -42,6 +42,34 @@ else() > ) > endif() > > +find_program(FLAKE8 flake8) > +if(FLAKE8) > + get_filename_component(FLAKE8_SOURCE_DIR "${PROJECT_SOURCE_DIR}" REALPATH) Nit: name FLAKE8_SOURCE_DIR is confused, because dir has nothing common with flake8. May be "REAL_SOURCE_DIR"? > + set(FLAKE8_RC ${FLAKE8_SOURCE_DIR}/.flake8rc) > + file(GLOB_RECURSE FLAKE8_DEPS ${FLAKE8_SOURCE_DIR}/*.py) > + add_custom_target(${PROJECT_NAME}-flake8 > + DEPENDS ${FLAKE8_DEPS} > + ) > + add_custom_command(TARGET ${PROJECT_NAME}-flake8 > + COMMENT "Running flake8 static analysis" > + COMMAND > + ${FLAKE8} ${FLAKE8_DEPS} > + --config ${FLAKE8_RC} > + --jobs ${CMAKE_BUILD_PARALLEL_LEVEL} > + WORKING_DIRECTORY ${FLAKE8_SOURCE_DIR} > + ) > +else() > + add_custom_target(${PROJECT_NAME}-flake8) > + add_custom_command(TARGET ${PROJECT_NAME}-flake8 > + COMMENT "`flake8' is not found, so ${PROJECT_NAME}-flake8 target is dummy" Please add a command to a dummy target: |COMMAND ${CMAKE_COMMAND} -E cmake_echo_color --red "||`flake8' is not found, so ${PROJECT_NAME}-flake8 target is dummy" with added COMMAND target will print a message | > + ) > +endif() > + > +add_custom_target(${PROJECT_NAME}-lint DEPENDS > + ${PROJECT_NAME}-luacheck > + ${PROJECT_NAME}-flake8 > +) > + > set(LUAJIT_TEST_COMMAND "${LUAJIT_TEST_BINARY} -e dofile[[${LUAJIT_TEST_INIT}]]") > separate_arguments(LUAJIT_TEST_COMMAND) > You've introduced a new target LuaJIT-lint, that includes LuaJIT-luacheck and LuaJIT-flake8. I suppose we need replace dependence "LuaJIT-luacheck" to "LuaJIT-lint" for a target "test". [-- Attachment #2: Type: text/html, Size: 7168 bytes --]
next prev parent reply other threads:[~2023-08-03 14:23 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-03 7:30 [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 01/15] test: fix E122 errors by pycodestyle Igor Munkin via Tarantool-patches 2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:49 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 02/15] test: fix E128 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:52 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 03/15] test: fix E201 and E202 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:53 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 04/15] test: fix E203 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 05/15] test: fix E231 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 06/15] test: fix E251 " Igor Munkin via Tarantool-patches 2023-08-03 14:27 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:58 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 07/15] test: fix E301 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:01 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 08/15] test: fix E302 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:02 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 09/15] test: fix E303 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:03 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 10/15] test: fix E305 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:05 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 11/15] test: fix E502 " Igor Munkin via Tarantool-patches 2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 12/15] test: fix E711 " Igor Munkin via Tarantool-patches 2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 13/15] test: fix E722 " Igor Munkin via Tarantool-patches 2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:10 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 14/15] test: fix E741 " Igor Munkin via Tarantool-patches 2023-08-03 14:34 ` Sergey Bronnikov via Tarantool-patches 2023-08-07 11:00 ` Igor Munkin via Tarantool-patches 2023-08-07 13:45 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:15 ` Maxim Kokryashkin via Tarantool-patches 2023-08-07 10:57 ` Igor Munkin via Tarantool-patches 2023-08-13 20:25 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Igor Munkin via Tarantool-patches 2023-08-03 14:23 ` Sergey Bronnikov via Tarantool-patches [this message] 2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches 2023-08-07 13:35 ` Igor Munkin via Tarantool-patches 2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 16/15] gdb: fix Python <assert> statement usage Igor Munkin via Tarantool-patches 2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-13 20:24 ` Maxim Kokryashkin via Tarantool-patches 2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 17/15] test: fix E275 errors by pycodestyle Igor Munkin via Tarantool-patches 2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-13 19:25 ` Maxim Kokryashkin via Tarantool-patches 2023-08-08 8:18 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Sergey Bronnikov via Tarantool-patches 2023-08-07 12:17 ` Igor Munkin via Tarantool-patches 2023-08-07 13:48 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 21:02 ` Maxim Kokryashkin via Tarantool-patches 2023-08-08 19:29 ` Igor Munkin via Tarantool-patches 2023-08-08 19:42 ` [Tarantool-patches] [PATCH luajit 18/15] test: suppress E131 errors by pycodestyle Igor Munkin via Tarantool-patches 2023-08-13 13:52 ` Maxim Kokryashkin via Tarantool-patches 2023-08-08 19:42 ` [Tarantool-patches] [PATCH luajit 19/15] test: fix E501 " Igor Munkin via Tarantool-patches 2023-08-13 13:55 ` Maxim Kokryashkin via Tarantool-patches 2023-08-14 7:28 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Maxim Kokryashkin via Tarantool-patches 2023-08-21 11:05 ` [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2f20f91c-1336-b34b-6681-3947e96b486d@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox