From: Maxim Kokryashkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: "Igor Munkin" <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 02/15] test: fix E128 errors by pycodestyle
Date: Thu, 03 Aug 2023 18:52:47 +0300 [thread overview]
Message-ID: <1691077967.75609317@f107.i.mail.ru> (raw)
In-Reply-To: <e2d3cb080329f8855588012e24a3b3e024c9f1c8.1691047132.git.imun@tarantool.org>
[-- Attachment #1: Type: text/plain, Size: 2976 bytes --]
Hi, Igor!
Thanks for the patch!
LGTM
--
Best regards,
Maxim Kokryashkin
>
>>Fixed 8 occurrences of E128 ("continuation line under-indented for
>>visual indent") error reported by pycodestyle[1].
>>
>>[1]: https://www.flake8rules.com/rules/E128.html
>>
>>Signed-off-by: Igor Munkin < imun@tarantool.org >
>>---
>> src/luajit-gdb.py | 13 ++++++-------
>> src/luajit_lldb.py | 6 +++---
>> 2 files changed, 9 insertions(+), 10 deletions(-)
>>
>>diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
>>index 96ee2289..b84fdc93 100644
>>--- a/src/luajit-gdb.py
>>+++ b/src/luajit-gdb.py
>>@@ -118,7 +118,7 @@ def bc_a(ins):
>>
>> def frame_ftsz(framelink):
>> return cast('ptrdiff_t', framelink['ftsz'] if LJ_FR2 \
>>- else framelink['fr']['tp']['ftsz'])
>>+ else framelink['fr']['tp']['ftsz'])
>>
>> def frame_pc(framelink):
>> return cast('BCIns *', frame_ftsz(framelink)) if LJ_FR2 \
>>@@ -182,11 +182,11 @@ def mref(typename, obj):
>>
>> def gcref(obj):
>> return cast('GCobj *', obj['gcptr64'] if LJ_GC64
>>- else cast('uintptr_t', obj['gcptr32']))
>>+ else cast('uintptr_t', obj['gcptr32']))
>>
>> def gcval(obj):
>> return cast('GCobj *', obj['gcptr64'] & LJ_GCVMASK if LJ_GC64
>>- else cast('uintptr_t', obj['gcptr32']))
>>+ else cast('uintptr_t', obj['gcptr32']))
>>
>> def gcnext(obj):
>> return gcref(obj)['gch']['nextgc']
>>@@ -212,9 +212,8 @@ def J(g):
>> typeGG = gtype('GG_State')
>>
>> return cast('jit_State *', int(cast('char *', g))
>>- - int(typeGG['g'].bitpos / 8)
>>- + int(typeGG['J'].bitpos / 8)
>>- )
>>+ - int(typeGG['g'].bitpos / 8)
>>+ + int(typeGG['J'].bitpos / 8))
>>
>> def vm_state(g):
>> return {
>>@@ -282,7 +281,7 @@ def funcproto(func):
>> assert(func['ffid'] == 0)
>>
>> return cast('GCproto *',
>>- mref('char *', func['pc']) - gdb.lookup_type('GCproto').sizeof)
>>+ mref('char *', func['pc']) - gdb.lookup_type('GCproto').sizeof)
>>
>> def gclistlen(root, end=0x0):
>> count = 0
>>diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py
>>index 77d92785..3f636546 100644
>>--- a/src/luajit_lldb.py
>>+++ b/src/luajit_lldb.py
>>@@ -355,11 +355,11 @@ def dbg_eval(expr):
>>
>> def gcval(obj):
>> return cast(GCobjPtr, cast('uintptr_t', obj.gcptr & LJ_GCVMASK) if LJ_GC64
>>- else cast('uintptr_t', obj.gcptr))
>>+ else cast('uintptr_t', obj.gcptr))
>>
>> def gcref(obj):
>> return cast(GCobjPtr, obj.gcptr if LJ_GC64
>>- else cast('uintptr_t', obj.gcptr))
>>+ else cast('uintptr_t', obj.gcptr))
>>
>> def gcnext(obj):
>> return gcref(obj).gch.nextgc
>>@@ -658,7 +658,7 @@ def bc_a(ins):
>>
>> def frame_ftsz(framelink):
>> return vtou64(cast('ptrdiff_t', framelink.ftsz if LJ_FR2 \
>>- else framelink.fr.tp.ftsz))
>>+ else framelink.fr.tp.ftsz))
>>
>> def frame_pc(framelink):
>> return cast(BCInsPtr, frame_ftsz(framelink)) if LJ_FR2 \
>>--
>>2.30.2
>
[-- Attachment #2: Type: text/html, Size: 4163 bytes --]
next prev parent reply other threads:[~2023-08-03 15:52 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 7:30 [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 01/15] test: fix E122 errors by pycodestyle Igor Munkin via Tarantool-patches
2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:49 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 02/15] test: fix E128 " Igor Munkin via Tarantool-patches
2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:52 ` Maxim Kokryashkin via Tarantool-patches [this message]
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 03/15] test: fix E201 and E202 " Igor Munkin via Tarantool-patches
2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:53 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 04/15] test: fix E203 " Igor Munkin via Tarantool-patches
2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 05/15] test: fix E231 " Igor Munkin via Tarantool-patches
2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 06/15] test: fix E251 " Igor Munkin via Tarantool-patches
2023-08-03 14:27 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:58 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 07/15] test: fix E301 " Igor Munkin via Tarantool-patches
2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:01 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 08/15] test: fix E302 " Igor Munkin via Tarantool-patches
2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:02 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 09/15] test: fix E303 " Igor Munkin via Tarantool-patches
2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:03 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 10/15] test: fix E305 " Igor Munkin via Tarantool-patches
2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:05 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 11/15] test: fix E502 " Igor Munkin via Tarantool-patches
2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 12/15] test: fix E711 " Igor Munkin via Tarantool-patches
2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 13/15] test: fix E722 " Igor Munkin via Tarantool-patches
2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:10 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 14/15] test: fix E741 " Igor Munkin via Tarantool-patches
2023-08-03 14:34 ` Sergey Bronnikov via Tarantool-patches
2023-08-07 11:00 ` Igor Munkin via Tarantool-patches
2023-08-07 13:45 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:15 ` Maxim Kokryashkin via Tarantool-patches
2023-08-07 10:57 ` Igor Munkin via Tarantool-patches
2023-08-13 20:25 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Igor Munkin via Tarantool-patches
2023-08-03 14:23 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches
2023-08-07 13:35 ` Igor Munkin via Tarantool-patches
2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 16/15] gdb: fix Python <assert> statement usage Igor Munkin via Tarantool-patches
2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-13 20:24 ` Maxim Kokryashkin via Tarantool-patches
2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 17/15] test: fix E275 errors by pycodestyle Igor Munkin via Tarantool-patches
2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-13 19:25 ` Maxim Kokryashkin via Tarantool-patches
2023-08-08 8:18 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Sergey Bronnikov via Tarantool-patches
2023-08-07 12:17 ` Igor Munkin via Tarantool-patches
2023-08-07 13:48 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 21:02 ` Maxim Kokryashkin via Tarantool-patches
2023-08-08 19:29 ` Igor Munkin via Tarantool-patches
2023-08-08 19:42 ` [Tarantool-patches] [PATCH luajit 18/15] test: suppress E131 errors by pycodestyle Igor Munkin via Tarantool-patches
2023-08-13 13:52 ` Maxim Kokryashkin via Tarantool-patches
2023-08-08 19:42 ` [Tarantool-patches] [PATCH luajit 19/15] test: fix E501 " Igor Munkin via Tarantool-patches
2023-08-13 13:55 ` Maxim Kokryashkin via Tarantool-patches
2023-08-14 7:28 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Maxim Kokryashkin via Tarantool-patches
2023-08-21 11:05 ` [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1691077967.75609317@f107.i.mail.ru \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 02/15] test: fix E128 errors by pycodestyle' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox