From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>,
Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 03/15] test: fix E201 and E202 errors by pycodestyle
Date: Thu, 3 Aug 2023 17:26:25 +0300 [thread overview]
Message-ID: <5dd220fb-5712-2c8e-0501-f72560c12183@tarantool.org> (raw)
In-Reply-To: <7e04eae9eadd01e9bad114c8f63557b1b33afee5.1691047132.git.imun@tarantool.org>
LGTM
On 8/3/23 10:30, Igor Munkin wrote:
> Fixed the only occurrence of E202 ("whitespace before ')'"), 7
> occurrences of E201 ("whitespace after '['") and 7 occurrences of E202
> ("whitespace before ']'") errors reported by pycodestyle[1][2].
>
> [1]: https://www.flake8rules.com/rules/E201.html
> [2]: https://www.flake8rules.com/rules/E202.html
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> src/luajit-gdb.py | 14 +++++++-------
> src/luajit_lldb.py | 12 ++++++------
> 2 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
> index b84fdc93..198578b1 100644
> --- a/src/luajit-gdb.py
> +++ b/src/luajit-gdb.py
> @@ -195,7 +195,7 @@ def L(L=None):
> # lookup a symbol for the main coroutine considering the host app
> # XXX Fragile: though the loop initialization looks like a crap but it
> # respects both Python 2 and Python 3.
> - for l in [ L ] + list(map(lambda l: lookup(l), (
> + for l in [L] + list(map(lambda l: lookup(l), (
> # LuaJIT main coro (see luajit/src/luajit.c)
> 'globalL',
> # Tarantool main coro (see tarantool/src/lua/init.h)
> @@ -504,20 +504,20 @@ def dump_stack(L, base=None, top=None):
>
> def dump_gc(g):
> gc = g['gc']
> - stats = [ '{key}: {value}'.format(key = f, value = gc[f]) for f in (
> + stats = ['{key}: {value}'.format(key = f, value = gc[f]) for f in (
> 'total', 'threshold', 'debt', 'estimate', 'stepmul', 'pause'
> - ) ]
> + )]
>
> - stats += [ 'sweepstr: {sweepstr}/{strmask}'.format(
> + stats += ['sweepstr: {sweepstr}/{strmask}'.format(
> sweepstr = gc['sweepstr'],
> # String hash mask (size of hash table - 1).
> strmask = g['strmask'] + 1,
> - ) ]
> + )]
>
> - stats += [ '{key}: {number} objects'.format(
> + stats += ['{key}: {number} objects'.format(
> key = stat,
> number = handler(gc[stat])
> - ) for stat, handler in gclen.items() ]
> + ) for stat, handler in gclen.items()]
>
> return '\n'.join(map(lambda s: '\t' + s, stats))
>
> diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py
> index 3f636546..2887723b 100644
> --- a/src/luajit_lldb.py
> +++ b/src/luajit_lldb.py
> @@ -211,7 +211,7 @@ c_structs = {
> }
>
> for cls in c_structs.keys():
> - globals()[cls] = type(cls, (Struct, ), {'metainfo': c_structs[cls]} )
> + globals()[cls] = type(cls, (Struct, ), {'metainfo': c_structs[cls]})
>
> for cls in Struct.__subclasses__():
> ptr_name = cls.__name__ + 'Ptr'
> @@ -394,16 +394,16 @@ def dump_gc(g):
> 'total', 'threshold', 'debt', 'estimate', 'stepmul', 'pause'
> )]
>
> - stats += [ 'sweepstr: {sweepstr}/{strmask}'.format(
> + stats += ['sweepstr: {sweepstr}/{strmask}'.format(
> sweepstr = gc.sweepstr,
> # String hash mask (size of hash table - 1).
> strmask = g.strmask + 1,
> - ) ]
> + )]
>
> - stats += [ '{key}: {number} objects'.format(
> + stats += ['{key}: {number} objects'.format(
> key = stat,
> number = handler(getattr(gc, stat))
> - ) for stat, handler in gclen.items() ]
> + ) for stat, handler in gclen.items()]
> return '\n'.join(map(lambda s: '\t' + s, stats))
>
> def mref(typename, obj):
> @@ -424,7 +424,7 @@ def L(L=None):
> # lookup a symbol for the main coroutine considering the host app
> # XXX Fragile: though the loop initialization looks like a crap but it
> # respects both Python 2 and Python 3.
> - for l in [ L ] + list(map(lambda l: lookup_global(l), (
> + for l in [L] + list(map(lambda l: lookup_global(l), (
> # LuaJIT main coro (see luajit/src/luajit.c)
> 'globalL',
> # Tarantool main coro (see tarantool/src/lua/init.h)
next prev parent reply other threads:[~2023-08-03 14:26 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 7:30 [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 01/15] test: fix E122 errors by pycodestyle Igor Munkin via Tarantool-patches
2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:49 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 02/15] test: fix E128 " Igor Munkin via Tarantool-patches
2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:52 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 03/15] test: fix E201 and E202 " Igor Munkin via Tarantool-patches
2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches [this message]
2023-08-03 15:53 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 04/15] test: fix E203 " Igor Munkin via Tarantool-patches
2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 05/15] test: fix E231 " Igor Munkin via Tarantool-patches
2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 06/15] test: fix E251 " Igor Munkin via Tarantool-patches
2023-08-03 14:27 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:58 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 07/15] test: fix E301 " Igor Munkin via Tarantool-patches
2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:01 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 08/15] test: fix E302 " Igor Munkin via Tarantool-patches
2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:02 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 09/15] test: fix E303 " Igor Munkin via Tarantool-patches
2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:03 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 10/15] test: fix E305 " Igor Munkin via Tarantool-patches
2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:05 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 11/15] test: fix E502 " Igor Munkin via Tarantool-patches
2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 12/15] test: fix E711 " Igor Munkin via Tarantool-patches
2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 13/15] test: fix E722 " Igor Munkin via Tarantool-patches
2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:10 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 14/15] test: fix E741 " Igor Munkin via Tarantool-patches
2023-08-03 14:34 ` Sergey Bronnikov via Tarantool-patches
2023-08-07 11:00 ` Igor Munkin via Tarantool-patches
2023-08-07 13:45 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:15 ` Maxim Kokryashkin via Tarantool-patches
2023-08-07 10:57 ` Igor Munkin via Tarantool-patches
2023-08-13 20:25 ` Maxim Kokryashkin via Tarantool-patches
2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Igor Munkin via Tarantool-patches
2023-08-03 14:23 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches
2023-08-07 13:35 ` Igor Munkin via Tarantool-patches
2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 16/15] gdb: fix Python <assert> statement usage Igor Munkin via Tarantool-patches
2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-13 20:24 ` Maxim Kokryashkin via Tarantool-patches
2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 17/15] test: fix E275 errors by pycodestyle Igor Munkin via Tarantool-patches
2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches
2023-08-13 19:25 ` Maxim Kokryashkin via Tarantool-patches
2023-08-08 8:18 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Sergey Bronnikov via Tarantool-patches
2023-08-07 12:17 ` Igor Munkin via Tarantool-patches
2023-08-07 13:48 ` Sergey Bronnikov via Tarantool-patches
2023-08-03 21:02 ` Maxim Kokryashkin via Tarantool-patches
2023-08-08 19:29 ` Igor Munkin via Tarantool-patches
2023-08-08 19:42 ` [Tarantool-patches] [PATCH luajit 18/15] test: suppress E131 errors by pycodestyle Igor Munkin via Tarantool-patches
2023-08-13 13:52 ` Maxim Kokryashkin via Tarantool-patches
2023-08-08 19:42 ` [Tarantool-patches] [PATCH luajit 19/15] test: fix E501 " Igor Munkin via Tarantool-patches
2023-08-13 13:55 ` Maxim Kokryashkin via Tarantool-patches
2023-08-14 7:28 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Maxim Kokryashkin via Tarantool-patches
2023-08-21 11:05 ` [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5dd220fb-5712-2c8e-0501-f72560c12183@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=m.kokryashkin@tarantool.org \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 03/15] test: fix E201 and E202 errors by pycodestyle' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox