From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org> To: Maxim Kokryashkin <m.kokryashkin@tarantool.org>, Sergey Bronnikov <sergeyb@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: [Tarantool-patches] [PATCH luajit 18/15] test: suppress E131 errors by pycodestyle Date: Tue, 8 Aug 2023 19:42:39 +0000 [thread overview] Message-ID: <2559a1d630bf893d22e6e37bef9d55710999832f.1691523040.git.imun@tarantool.org> (raw) In-Reply-To: <ZNKXqyzRbPEuC3QG@tarantool.org> Suppressed 4 occurrences of E131 ("continuation line unaligned for hanging indent") error reported by pycodestyle[1]. The reasons, why these violations are not fixed the way recommended in the docs are below: * The only difference between prefix and postfix loop statements (the latter is used in various generators and comprehensions) is the trailing colon. * The surrounding code is quite complex consisting of the cascade of the calls and list comprehensions. Hence, to emphasis the postfix loop used in list comprehensions, additional indent is preserved and inline <noqa> suppressions are added. [1]: https://www.flake8rules.com/rules/E131.html Signed-off-by: Igor Munkin <imun@tarantool.org> --- **NB**: This patch will be placed between "[PATCH luajit 02/15] test: fix E128 errors by pycodestyle" and "[PATCH luajit 03/15] test: fix E201 and E202 errors by pycodestyle" on the branch. CI: https://github.com/tarantool/luajit/actions/runs/5800936024/job/15724104222 src/luajit-gdb.py | 4 ++-- src/luajit_lldb.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py index f9623e53..9dcddb17 100644 --- a/src/luajit-gdb.py +++ b/src/luajit-gdb.py @@ -553,7 +553,7 @@ def dump_stack(L, base=None, top=None): ] dump.extend([ dump_stack_slot(L, maxstack + offset, base, top) - for offset in range(red, 0, -1) + for offset in range(red, 0, -1) # noqa: E131 ]) dump.extend([ '{padding} Stack: {nstackslots: >5} slots {padding}'.format( @@ -572,7 +572,7 @@ def dump_stack(L, base=None, top=None): # Dump all data slots in the (framelink, top) interval. dump.extend([ dump_stack_slot(L, framelink + offset, base, top) - for offset in range(frametop - framelink, 0, -1) + for offset in range(frametop - framelink, 0, -1) # noqa: E131 ]) # Dump frame slot (2 slots in case of GC64). dump.append(dump_framelink(L, framelink)) diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py index 53f3abca..13d9f2e3 100644 --- a/src/luajit_lldb.py +++ b/src/luajit_lldb.py @@ -844,7 +844,7 @@ def dump_stack(L, base=None, top=None): ] dump.extend([ dump_stack_slot(L, maxstack + offset, base, top) - for offset in range(red, 0, -1) + for offset in range(red, 0, -1) # noqa: E131 ]) dump.extend([ '{padding} Stack: {nstackslots: >5} slots {padding}'.format( @@ -864,7 +864,7 @@ def dump_stack(L, base=None, top=None): # Dump all data slots in the (framelink, top) interval. dump.extend([ dump_stack_slot(L, framelink + offset, base, top) - for offset in range(frametop - framelink, 0, -1) + for offset in range(frametop - framelink, 0, -1) # noqa: E131 ]) # Dump frame slot (2 slots in case of GC64). dump.append(dump_framelink(L, framelink)) -- 2.30.2
next prev parent reply other threads:[~2023-08-08 19:56 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-08-03 7:30 [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 01/15] test: fix E122 errors by pycodestyle Igor Munkin via Tarantool-patches 2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:49 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 02/15] test: fix E128 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:52 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 03/15] test: fix E201 and E202 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:53 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 04/15] test: fix E203 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 05/15] test: fix E231 " Igor Munkin via Tarantool-patches 2023-08-03 14:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:55 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 06/15] test: fix E251 " Igor Munkin via Tarantool-patches 2023-08-03 14:27 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 15:58 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 07/15] test: fix E301 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:01 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 08/15] test: fix E302 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:02 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 09/15] test: fix E303 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:03 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 10/15] test: fix E305 " Igor Munkin via Tarantool-patches 2023-08-03 14:28 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:05 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 11/15] test: fix E502 " Igor Munkin via Tarantool-patches 2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 12/15] test: fix E711 " Igor Munkin via Tarantool-patches 2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:06 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 13/15] test: fix E722 " Igor Munkin via Tarantool-patches 2023-08-03 14:29 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:10 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 14/15] test: fix E741 " Igor Munkin via Tarantool-patches 2023-08-03 14:34 ` Sergey Bronnikov via Tarantool-patches 2023-08-07 11:00 ` Igor Munkin via Tarantool-patches 2023-08-07 13:45 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 16:15 ` Maxim Kokryashkin via Tarantool-patches 2023-08-07 10:57 ` Igor Munkin via Tarantool-patches 2023-08-13 20:25 ` Maxim Kokryashkin via Tarantool-patches 2023-08-03 7:30 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Igor Munkin via Tarantool-patches 2023-08-03 14:23 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 14:25 ` Sergey Bronnikov via Tarantool-patches 2023-08-07 13:35 ` Igor Munkin via Tarantool-patches 2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 16/15] gdb: fix Python <assert> statement usage Igor Munkin via Tarantool-patches 2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-13 20:24 ` Maxim Kokryashkin via Tarantool-patches 2023-08-07 13:41 ` [Tarantool-patches] [PATCH luajit 17/15] test: fix E275 errors by pycodestyle Igor Munkin via Tarantool-patches 2023-08-08 8:26 ` Sergey Bronnikov via Tarantool-patches 2023-08-13 19:25 ` Maxim Kokryashkin via Tarantool-patches 2023-08-08 8:18 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Sergey Bronnikov via Tarantool-patches 2023-08-07 12:17 ` Igor Munkin via Tarantool-patches 2023-08-07 13:48 ` Sergey Bronnikov via Tarantool-patches 2023-08-03 21:02 ` Maxim Kokryashkin via Tarantool-patches 2023-08-08 19:29 ` Igor Munkin via Tarantool-patches 2023-08-08 19:42 ` Igor Munkin via Tarantool-patches [this message] 2023-08-13 13:52 ` [Tarantool-patches] [PATCH luajit 18/15] test: suppress E131 errors by pycodestyle Maxim Kokryashkin via Tarantool-patches 2023-08-08 19:42 ` [Tarantool-patches] [PATCH luajit 19/15] test: fix E501 " Igor Munkin via Tarantool-patches 2023-08-13 13:55 ` Maxim Kokryashkin via Tarantool-patches 2023-08-14 7:28 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Maxim Kokryashkin via Tarantool-patches 2023-08-21 11:05 ` [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2559a1d630bf893d22e6e37bef9d55710999832f.1691523040.git.imun@tarantool.org \ --to=tarantool-patches@dev.tarantool.org \ --cc=imun@tarantool.org \ --cc=m.kokryashkin@tarantool.org \ --cc=sergeyb@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit 18/15] test: suppress E131 errors by pycodestyle' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox