Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>,
	Maxim Kokryashkin <m.kokryashkin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 10/15] test: fix E305 errors by pycodestyle
Date: Thu, 3 Aug 2023 17:28:55 +0300	[thread overview]
Message-ID: <18cf4858-3492-3f99-d279-31248b014263@tarantool.org> (raw)
In-Reply-To: <8bbf5e3f00102d4e71f451c82de00bafe775518c.1691047132.git.imun@tarantool.org>

LGTM

On 8/3/23 10:30, Igor Munkin wrote:
> Fixed 10 occurrences of E305 ("expected 2 blank lines after class or
> function definition, found 1") error reported by pycodestyle[1].
> Furthermore, some other spots have been re-aligned the similar way to be
> in sync with the default code style.
>
> [1]: https://www.flake8rules.com/rules/E305.html
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>   src/luajit-gdb.py  | 15 +++++++++++++++
>   src/luajit_lldb.py | 10 ++++++++++
>   2 files changed, 25 insertions(+)
>
> diff --git a/src/luajit-gdb.py b/src/luajit-gdb.py
> index 9c51be0b..3babb1d5 100644
> --- a/src/luajit-gdb.py
> +++ b/src/luajit-gdb.py
> @@ -7,6 +7,7 @@ import sys
>   
>   # make script compatible with the ancient Python {{{
>   
> +
>   LEGACY = re.match(r'^2\.', sys.version)
>   
>   if LEGACY:
> @@ -14,8 +15,10 @@ if LEGACY:
>       int = long
>       range = xrange
>   
> +
>   # }}}
>   
> +
>   gtype_cache = {}
>   
>   
> @@ -70,8 +73,10 @@ def strx64(val):
>       return re.sub('L?$', '',
>                     hex(int(cast('uint64_t', val) & 0xFFFFFFFFFFFFFFFF)))
>   
> +
>   # Types {{{
>   
> +
>   LJ_T = {
>       'NIL':     i2notu32(0),
>       'FALSE':   i2notu32(1),
> @@ -95,10 +100,12 @@ def typenames(value):
>           LJ_T[k]: 'LJ_T' + k for k in LJ_T.keys()
>       }.get(int(value), 'LJ_TINVALID')
>   
> +
>   # }}}
>   
>   # Frames {{{
>   
> +
>   FRAME_TYPE = 0x3
>   FRAME_P = 0x4
>   FRAME_TYPEP = FRAME_TYPE | FRAME_P
> @@ -175,10 +182,12 @@ def frame_prev(framelink):
>   def frame_sentinel(L):
>       return mref('TValue *', L['stack']) + LJ_FR2
>   
> +
>   # }}}
>   
>   # Const {{{
>   
> +
>   LJ_64 = None
>   LJ_GC64 = None
>   LJ_FR2 = None
> @@ -194,6 +203,7 @@ LJ_LIGHTUD_BITS_LO = 47 - LJ_LIGHTUD_BITS_SEG
>   LIGHTUD_SEG_MASK = (1 << LJ_LIGHTUD_BITS_SEG) - 1
>   LIGHTUD_LO_MASK = (1 << LJ_LIGHTUD_BITS_LO) - 1
>   
> +
>   # }}}
>   
>   
> @@ -339,6 +349,7 @@ def gcringlen(root):
>       else:
>           return 1 + gclistlen(gcnext(root), gcref(root))
>   
> +
>   gclen = {
>       'root':      gclistlen,
>       'gray':      gclistlen,
> @@ -374,6 +385,7 @@ def lightudV(tv):
>       else:
>           return gcval(tv['gcr'])
>   
> +
>   # Dumpers {{{
>   
>   
> @@ -465,8 +477,10 @@ def dump_lj_tnumx(tv):
>   def dump_lj_invalid(tv):
>       return 'not valid type @ {}'.format(strx64(gcval(tv['gcr'])))
>   
> +
>   # }}}
>   
> +
>   dumpers = {
>       'LJ_TNIL':     dump_lj_tnil,
>       'LJ_TFALSE':   dump_lj_tfalse,
> @@ -867,4 +881,5 @@ def load(event=None):
>           'lj-gc':    LJGC,
>       })
>   
> +
>   load(None)
> diff --git a/src/luajit_lldb.py b/src/luajit_lldb.py
> index bdd9e716..325b40ec 100644
> --- a/src/luajit_lldb.py
> +++ b/src/luajit_lldb.py
> @@ -18,6 +18,8 @@ LJ_GCVMASK = ((1 << 47) - 1)
>   LJ_TISNUM = None
>   
>   # Debugger specific {{{
> +
> +
>   # Global
>   target = None
>   
> @@ -121,6 +123,7 @@ class Struct(metaclass=MetaStruct):
>       def addr(self):
>           return self.value.address_of
>   
> +
>   c_structs = {
>       'MRef': [
>           (property(lambda self: self['ptr64'].unsigned if LJ_GC64 else self['ptr32'].unsigned), 'ptr')
> @@ -212,9 +215,11 @@ c_structs = {
>       'BCIns': []
>   }
>   
> +
>   for cls in c_structs.keys():
>       globals()[cls] = type(cls, (Struct, ), {'metainfo': c_structs[cls]})
>   
> +
>   for cls in Struct.__subclasses__():
>       ptr_name = cls.__name__ + 'Ptr'
>   
> @@ -363,6 +368,7 @@ def dbg_eval(expr):
>       frame = thread.GetSelectedFrame()
>       return frame.EvaluateExpression(expr)
>   
> +
>   # }}} Debugger specific
>   
>   
> @@ -396,6 +402,7 @@ def gcringlen(root):
>       else:
>           return 1 + gclistlen(gcnext(root), gcref(root))
>   
> +
>   gclen = {
>       'root':      gclistlen,
>       'gray':      gclistlen,
> @@ -630,6 +637,7 @@ def dump_lj_tnumx(tv):
>   def dump_lj_invalid(tv):
>       return 'not valid type @ {}'.format(strx64(gcval(tv.gcr)))
>   
> +
>   dumpers = {
>       'LJ_TNIL':     dump_lj_tnil,
>       'LJ_TFALSE':   dump_lj_tfalse,
> @@ -647,6 +655,7 @@ dumpers = {
>       'LJ_TNUMX':    dump_lj_tnumx,
>   }
>   
> +
>   LJ_T = {
>       'NIL':     i2notu32(0),
>       'FALSE':   i2notu32(1),
> @@ -682,6 +691,7 @@ def typenames(value):
>   def dump_tvalue(tvptr):
>       return dumpers.get(typenames(itypemap(tvptr)), dump_lj_invalid)(tvptr)
>   
> +
>   FRAME_TYPE = 0x3
>   FRAME_P = 0x4
>   FRAME_TYPEP = FRAME_TYPE | FRAME_P

  reply	other threads:[~2023-08-03 14:30 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  7:30 [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 01/15] test: fix E122 errors by pycodestyle Igor Munkin via Tarantool-patches
2023-08-03 14:25   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:49   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 02/15] test: fix E128 " Igor Munkin via Tarantool-patches
2023-08-03 14:26   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:52   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 03/15] test: fix E201 and E202 " Igor Munkin via Tarantool-patches
2023-08-03 14:26   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:53   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 04/15] test: fix E203 " Igor Munkin via Tarantool-patches
2023-08-03 14:26   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:55   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 05/15] test: fix E231 " Igor Munkin via Tarantool-patches
2023-08-03 14:26   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:55   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 06/15] test: fix E251 " Igor Munkin via Tarantool-patches
2023-08-03 14:27   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 15:58   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 07/15] test: fix E301 " Igor Munkin via Tarantool-patches
2023-08-03 14:28   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:01   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 08/15] test: fix E302 " Igor Munkin via Tarantool-patches
2023-08-03 14:28   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:02   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 09/15] test: fix E303 " Igor Munkin via Tarantool-patches
2023-08-03 14:28   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:03   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 10/15] test: fix E305 " Igor Munkin via Tarantool-patches
2023-08-03 14:28   ` Sergey Bronnikov via Tarantool-patches [this message]
2023-08-03 16:05   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 11/15] test: fix E502 " Igor Munkin via Tarantool-patches
2023-08-03 14:29   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:06   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 12/15] test: fix E711 " Igor Munkin via Tarantool-patches
2023-08-03 14:29   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:06   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 13/15] test: fix E722 " Igor Munkin via Tarantool-patches
2023-08-03 14:29   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:10   ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 14/15] test: fix E741 " Igor Munkin via Tarantool-patches
2023-08-03 14:34   ` Sergey Bronnikov via Tarantool-patches
2023-08-07 11:00     ` Igor Munkin via Tarantool-patches
2023-08-07 13:45       ` Sergey Bronnikov via Tarantool-patches
2023-08-03 16:15   ` Maxim Kokryashkin via Tarantool-patches
2023-08-07 10:57     ` Igor Munkin via Tarantool-patches
2023-08-13 20:25       ` Maxim Kokryashkin via Tarantool-patches
2023-08-03  7:30 ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Igor Munkin via Tarantool-patches
2023-08-03 14:23   ` Sergey Bronnikov via Tarantool-patches
2023-08-03 14:25     ` Sergey Bronnikov via Tarantool-patches
2023-08-07 13:35       ` Igor Munkin via Tarantool-patches
2023-08-07 13:41         ` [Tarantool-patches] [PATCH luajit 16/15] gdb: fix Python <assert> statement usage Igor Munkin via Tarantool-patches
2023-08-08  8:26           ` Sergey Bronnikov via Tarantool-patches
2023-08-13 20:24           ` Maxim Kokryashkin via Tarantool-patches
2023-08-07 13:41         ` [Tarantool-patches] [PATCH luajit 17/15] test: fix E275 errors by pycodestyle Igor Munkin via Tarantool-patches
2023-08-08  8:26           ` Sergey Bronnikov via Tarantool-patches
2023-08-13 19:25           ` Maxim Kokryashkin via Tarantool-patches
2023-08-08  8:18         ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Sergey Bronnikov via Tarantool-patches
2023-08-07 12:17     ` Igor Munkin via Tarantool-patches
2023-08-07 13:48       ` Sergey Bronnikov via Tarantool-patches
2023-08-03 21:02   ` Maxim Kokryashkin via Tarantool-patches
2023-08-08 19:29     ` Igor Munkin via Tarantool-patches
2023-08-08 19:42       ` [Tarantool-patches] [PATCH luajit 18/15] test: suppress E131 errors by pycodestyle Igor Munkin via Tarantool-patches
2023-08-13 13:52         ` Maxim Kokryashkin via Tarantool-patches
2023-08-08 19:42       ` [Tarantool-patches] [PATCH luajit 19/15] test: fix E501 " Igor Munkin via Tarantool-patches
2023-08-13 13:55         ` Maxim Kokryashkin via Tarantool-patches
2023-08-14  7:28       ` [Tarantool-patches] [PATCH luajit 15/15] test: run flake8 static analysis via CMake Maxim Kokryashkin via Tarantool-patches
2023-08-21 11:05 ` [Tarantool-patches] [PATCH luajit 00/15] Add flake8 linter Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=18cf4858-3492-3f99-d279-31248b014263@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=m.kokryashkin@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 10/15] test: fix E305 errors by pycodestyle' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox