From: Sergey Ostanevich <sergos@tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/7] utils: introduce leb128 reader and writer
Date: Sat, 26 Dec 2020 21:47:29 +0300 [thread overview]
Message-ID: <50DF01A5-0A59-459A-8B3E-2C7E2EC60871@tarantool.org> (raw)
In-Reply-To: <20201226135744.GW9101@root>
Hi!
LGTM.
Sergos
> On 26 Dec 2020, at 16:57, Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org> wrote:
>
> Sorry for my Runglish again.
> Change back articles "an uint" -> "a uint".
>
> See the iterative patch below. Branch is force-pushed.
> ===================================================================
> diff --git a/src/lj_utils.h b/src/lj_utils.h
> index 63d6c84..f5c1579 100644
> --- a/src/lj_utils.h
> +++ b/src/lj_utils.h
> @@ -29,13 +29,13 @@ size_t LJ_FASTCALL lj_utils_read_leb128_n(int64_t *out, const uint8_t *buffer,
> size_t n);
>
> /*
> -** Reads a value from a buffer of bytes to an uint64_t output.
> +** Reads a value from a buffer of bytes to a uint64_t output.
> ** No bounds checks for the buffer. Returns number of bytes read.
> */
> size_t LJ_FASTCALL lj_utils_read_uleb128(uint64_t *out, const uint8_t *buffer);
>
> /*
> -** Reads a value from a buffer of bytes to an uint64_t output. Consumes no more
> +** Reads a value from a buffer of bytes to a uint64_t output. Consumes no more
> ** than n bytes. No bounds checks for the buffer. Returns number of bytes
> ** read. If more than n bytes is about to be consumed, returns 0 without
> ** touching out.
> ===================================================================
>
> --
> Best regards,
> Sergey Kaplun
next prev parent reply other threads:[~2020-12-26 18:47 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-25 15:26 [Tarantool-patches] [PATCH luajit v2 0/7] LuaJIT memory profiler Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 1/7] utils: introduce leb128 reader and writer Sergey Kaplun
2020-12-25 21:42 ` Igor Munkin
2020-12-26 9:32 ` Sergey Kaplun
2020-12-26 13:57 ` Sergey Kaplun
2020-12-26 18:47 ` Sergey Ostanevich [this message]
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 2/7] core: introduce write buffer module Sergey Kaplun
2020-12-26 14:22 ` Igor Munkin
2020-12-26 15:26 ` Sergey Kaplun
2020-12-26 19:03 ` Sergey Ostanevich
2020-12-26 19:37 ` Sergey Kaplun
2020-12-28 1:43 ` Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 3/7] vm: introduce VM states for Lua and fast functions Sergey Kaplun
2020-12-26 19:07 ` Sergey Ostanevich
2020-12-27 23:48 ` Igor Munkin
2020-12-28 3:54 ` Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 4/7] core: introduce new mem_L field Sergey Kaplun
2020-12-26 19:12 ` Sergey Ostanevich
2020-12-26 19:42 ` Sergey Kaplun
2020-12-27 13:09 ` Igor Munkin
2020-12-27 17:44 ` Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 5/7] core: introduce memory profiler Sergey Kaplun
2020-12-27 10:58 ` Sergey Ostanevich
2020-12-27 11:54 ` Sergey Kaplun
2020-12-27 13:27 ` Sergey Ostanevich
2020-12-27 16:44 ` Igor Munkin
2020-12-27 21:47 ` Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 6/7] misc: add Lua API for " Sergey Kaplun
2020-12-27 11:54 ` Sergey Ostanevich
2020-12-27 13:42 ` Sergey Kaplun
2020-12-27 15:37 ` Sergey Ostanevich
2020-12-27 18:58 ` Igor Munkin
2020-12-28 0:14 ` Sergey Kaplun
2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 7/7] tools: introduce a memory profile parser Sergey Kaplun
2020-12-26 22:56 ` Igor Munkin
2020-12-27 7:16 ` Sergey Kaplun
2020-12-28 5:30 ` Sergey Kaplun
2020-12-28 5:33 ` Igor Munkin
2020-12-28 6:28 ` Sergey Kaplun
2020-12-28 6:31 ` Igor Munkin
2020-12-27 13:24 ` Sergey Ostanevich
2020-12-27 16:02 ` Sergey Kaplun
2020-12-27 21:55 ` Sergey Ostanevich
2020-12-28 2:05 ` [Tarantool-patches] [PATCH luajit v3 2/2] misc: add Lua API for memory profiler Sergey Kaplun
2020-12-28 2:49 ` Igor Munkin
2020-12-28 5:19 ` Sergey Kaplun
2020-12-28 2:06 ` [Tarantool-patches] [PATCH luajit v3 1/2] core: introduce " Sergey Kaplun
2020-12-28 3:59 ` Igor Munkin
2020-12-28 4:05 ` [Tarantool-patches] [PATCH luajit v3 3/7] vm: introduce VM states for Lua and fast functions Sergey Kaplun
2020-12-28 5:14 ` Igor Munkin
2020-12-28 6:01 ` [Tarantool-patches] [PATCH luajit v2 0/7] LuaJIT memory profiler Alexander V. Tikhonov
2020-12-28 8:15 ` Igor Munkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50DF01A5-0A59-459A-8B3E-2C7E2EC60871@tarantool.org \
--to=sergos@tarantool.org \
--cc=skaplun@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit v2 1/7] utils: introduce leb128 reader and writer' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox