From: Igor Munkin <imun@tarantool.org> To: Sergey Kaplun <skaplun@tarantool.org> Cc: tarantool-patches@dev.tarantool.org Subject: Re: [Tarantool-patches] [PATCH luajit v3 1/2] core: introduce memory profiler Date: Mon, 28 Dec 2020 06:59:27 +0300 [thread overview] Message-ID: <20201228035927.GO5396@tarantool.org> (raw) In-Reply-To: <20201228020620.2284-1-skaplun@tarantool.org> Sergey, Thanks for the fixes! LGTM. On 28.12.20, Sergey Kaplun wrote: > This patch introduces memory profiler for Lua machine. > > To determine currently allocating coroutine (that may not be equal to > currently executed one) a new field mem_L is added to the > global_State structure. This field is set on each allocation event and > stores the coroutine address that is used for allocation. > > First of all profiler dumps the definitions of all loaded Lua functions > (symtab) via the write buffer introduced in one of the previous patches. > > Profiler replaces the old allocation function with the instrumented one > after symtab is dumped. This new function reports all allocations, > reallocations or deallocations events via the write buffer during > profiling. Subsequent content depends on the function's type (LFUNC, > FFUNC or CFUNC). > > When profiling is over, a special epilogue event header is written and > the old allocation function is restored back. > > This change also makes debug_frameline function LuaJIT-wide visible to > be used in the memory profiler. > > For more information, see <lj_memprof.h>. > > Part of tarantool/tarantool#5442 > --- > > Changes in v3: > * Fixed invalid pointer usage at on_stop cb. > * Dropped thread safe logic. > * Dropped unused functions. > * Added assertion to memprof_write_lfunc. > * Codestyle fixes. > > src/Makefile | 5 +- > src/Makefile.dep | 30 +++-- > src/lj_arch.h | 15 +++ > src/lj_debug.c | 8 +- > src/lj_debug.h | 3 + > src/lj_gc.c | 7 +- > src/lj_gc.h | 1 + > src/lj_memprof.c | 344 +++++++++++++++++++++++++++++++++++++++++++++++ > src/lj_memprof.h | 159 ++++++++++++++++++++++ > src/lj_obj.h | 1 + > src/lj_state.c | 7 + > src/ljamalg.c | 1 + > 12 files changed, 561 insertions(+), 20 deletions(-) > create mode 100644 src/lj_memprof.c > create mode 100644 src/lj_memprof.h > <snipped> > -- > 2.28.0 > -- Best regards, IM
next prev parent reply other threads:[~2020-12-28 3:59 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-25 15:26 [Tarantool-patches] [PATCH luajit v2 0/7] LuaJIT " Sergey Kaplun 2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 1/7] utils: introduce leb128 reader and writer Sergey Kaplun 2020-12-25 21:42 ` Igor Munkin 2020-12-26 9:32 ` Sergey Kaplun 2020-12-26 13:57 ` Sergey Kaplun 2020-12-26 18:47 ` Sergey Ostanevich 2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 2/7] core: introduce write buffer module Sergey Kaplun 2020-12-26 14:22 ` Igor Munkin 2020-12-26 15:26 ` Sergey Kaplun 2020-12-26 19:03 ` Sergey Ostanevich 2020-12-26 19:37 ` Sergey Kaplun 2020-12-28 1:43 ` Sergey Kaplun 2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 3/7] vm: introduce VM states for Lua and fast functions Sergey Kaplun 2020-12-26 19:07 ` Sergey Ostanevich 2020-12-27 23:48 ` Igor Munkin 2020-12-28 3:54 ` Sergey Kaplun 2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 4/7] core: introduce new mem_L field Sergey Kaplun 2020-12-26 19:12 ` Sergey Ostanevich 2020-12-26 19:42 ` Sergey Kaplun 2020-12-27 13:09 ` Igor Munkin 2020-12-27 17:44 ` Sergey Kaplun 2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 5/7] core: introduce memory profiler Sergey Kaplun 2020-12-27 10:58 ` Sergey Ostanevich 2020-12-27 11:54 ` Sergey Kaplun 2020-12-27 13:27 ` Sergey Ostanevich 2020-12-27 16:44 ` Igor Munkin 2020-12-27 21:47 ` Sergey Kaplun 2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 6/7] misc: add Lua API for " Sergey Kaplun 2020-12-27 11:54 ` Sergey Ostanevich 2020-12-27 13:42 ` Sergey Kaplun 2020-12-27 15:37 ` Sergey Ostanevich 2020-12-27 18:58 ` Igor Munkin 2020-12-28 0:14 ` Sergey Kaplun 2020-12-25 15:26 ` [Tarantool-patches] [PATCH luajit v2 7/7] tools: introduce a memory profile parser Sergey Kaplun 2020-12-26 22:56 ` Igor Munkin 2020-12-27 7:16 ` Sergey Kaplun 2020-12-28 5:30 ` Sergey Kaplun 2020-12-28 5:33 ` Igor Munkin 2020-12-28 6:28 ` Sergey Kaplun 2020-12-28 6:31 ` Igor Munkin 2020-12-27 13:24 ` Sergey Ostanevich 2020-12-27 16:02 ` Sergey Kaplun 2020-12-27 21:55 ` Sergey Ostanevich 2020-12-28 2:05 ` [Tarantool-patches] [PATCH luajit v3 2/2] misc: add Lua API for memory profiler Sergey Kaplun 2020-12-28 2:49 ` Igor Munkin 2020-12-28 5:19 ` Sergey Kaplun 2020-12-28 2:06 ` [Tarantool-patches] [PATCH luajit v3 1/2] core: introduce " Sergey Kaplun 2020-12-28 3:59 ` Igor Munkin [this message] 2020-12-28 4:05 ` [Tarantool-patches] [PATCH luajit v3 3/7] vm: introduce VM states for Lua and fast functions Sergey Kaplun 2020-12-28 5:14 ` Igor Munkin 2020-12-28 6:01 ` [Tarantool-patches] [PATCH luajit v2 0/7] LuaJIT memory profiler Alexander V. Tikhonov 2020-12-28 8:15 ` Igor Munkin 2020-12-28 1:57 [Tarantool-patches] [PATCH luajit v3 1/2] core: introduce " Sergey Kaplun 2020-12-28 2:08 ` Sergey Kaplun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201228035927.GO5396@tarantool.org \ --to=imun@tarantool.org \ --cc=skaplun@tarantool.org \ --cc=tarantool-patches@dev.tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH luajit v3 1/2] core: introduce memory profiler' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox