Re: [Tarantool-patches] [PATCH luajit v2 4/7] core: introduce new mem_L field

[Igor Munkin <imun@tarantool.org>]

Sergey,

Thanks for the patch! I guess this commit can be squashed with the
following (introducing memprof engine), since <mem_L> field is added
only to make it work. Also consider my comments below.

On 25.12.20, Sergey Kaplun wrote:
> To determine currently allocating coroutine (that may not be equal to
> currently executed one) a new field called mem_L is added to
> global_State structure. This field is set on each allocation event and
> stores the coroutine address that is used for allocation.
> 
> Part of tarantool/tarantool#5442
> ---
>  src/lj_gc.c  | 2 ++
>  src/lj_obj.h | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/src/lj_gc.c b/src/lj_gc.c
> index 44c8aa1..800fb2c 100644
> --- a/src/lj_gc.c
> +++ b/src/lj_gc.c
> @@ -852,6 +852,8 @@ void *lj_mem_realloc(lua_State *L, void *p, GCSize osz, GCSize nsz)
>  {
>    global_State *g = G(L);
>    lua_assert((osz == 0) == (p == NULL));
> +
> +  setgcref(g->mem_L, obj2gco(L));

This field is initialized only here. What about <lj_mem_newgco> and
<lj_mem_free>? As for the latter the initialization is not necessary,
since all deallocations are reported as internals (but the comment
strongly required), but this assignment is definitely lost in the first
routine.

>    p = g->allocf(g->allocd, p, osz, nsz);
>    if (p == NULL && nsz > 0)
>      lj_err_mem(L);

<snipped>

> -- 
> 2.28.0
> 

-- 
Best regards,
IM