From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1A2244765E0
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 26 Dec 2020 21:47:32 +0300 (MSK)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
From: Sergey Ostanevich <sergos@tarantool.org>
In-Reply-To: <20201226135744.GW9101@root>
Date: Sat, 26 Dec 2020 21:47:29 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <50DF01A5-0A59-459A-8B3E-2C7E2EC60871@tarantool.org>
References: <cover.1608907726.git.skaplun@tarantool.org>
 <cacf5ad9ec0cf3a2633f1dff23ba1a3b44ecc4aa.1608907726.git.skaplun@tarantool.org>
 <20201225214245.GG5396@tarantool.org> <20201226093252.GV9101@root>
 <20201226135744.GW9101@root>
Subject: Re: [Tarantool-patches] [PATCH luajit v2 1/7] utils: introduce
 leb128 reader and writer
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

LGTM.

Sergos

> On 26 Dec 2020, at 16:57, Sergey Kaplun via Tarantool-patches =
<tarantool-patches@dev.tarantool.org> wrote:
>=20
> Sorry for my Runglish again.
> Change back articles "an uint" -> "a uint".
>=20
> See the iterative patch below. Branch is force-pushed.
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> diff --git a/src/lj_utils.h b/src/lj_utils.h
> index 63d6c84..f5c1579 100644
> --- a/src/lj_utils.h
> +++ b/src/lj_utils.h
> @@ -29,13 +29,13 @@ size_t LJ_FASTCALL lj_utils_read_leb128_n(int64_t =
*out, const uint8_t *buffer,
> 					  size_t n);
>=20
> /*
> -** Reads a value from a buffer of bytes to an uint64_t output.
> +** Reads a value from a buffer of bytes to a uint64_t output.
> ** No bounds checks for the buffer. Returns number of bytes read.
> */
> size_t LJ_FASTCALL lj_utils_read_uleb128(uint64_t *out, const uint8_t =
*buffer);
>=20
> /*
> -** Reads a value from a buffer of bytes to an uint64_t output. =
Consumes no more
> +** Reads a value from a buffer of bytes to a uint64_t output. =
Consumes no more
> ** than n bytes. No bounds checks for the buffer. Returns number of =
bytes
> ** read. If more than n bytes is about to be consumed, returns 0 =
without
> ** touching out.
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
>=20
> --=20
> Best regards,
> Sergey Kaplun