[Tarantool-patches] [PATCH luajit] test: fix checking macro support in dbg tests

[Tarantool-patches] [PATCH luajit] test: fix checking macro support in dbg tests

[Mikhail Elhimov via Tarantool-patches]

follow-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b
---
Branch: https://github.com/tarantool/luajit/tree/elhimov/gh-noticket-test-dbg-fix-checking-macro-support

 test/tarantool-debugger-tests/debug-extension-tests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
index 895171a4..ab44121c 100644
--- a/test/tarantool-debugger-tests/debug-extension-tests.py
+++ b/test/tarantool-debugger-tests/debug-extension-tests.py
@@ -172,7 +172,7 @@ class TestCaseBase(unittest.TestCase):
 def check_macro_debug_info():
     cmd_file = persist('\n'.join([
         'b lj_cf_print',
-        *PROCESS_RUN,
+        PROCESS_RUN,
         'n',
         'p gcval(L->base)',
         'q',
-- 
2.43.0

Re: [Tarantool-patches] [PATCH luajit] test: fix checking macro support in dbg tests

[Sergey Kaplun via Tarantool-patches]

Hi, Mikhail!
Thanks for the patch!
Honestly, I don't understand what problem it solves. Could you please
add a more verbose commit message?

On 09.09.26, Mikhail Elhimov wrote:
> follow-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b
> ---
> Branch: https://github.com/tarantool/luajit/tree/elhimov/gh-noticket-test-dbg-fix-checking-macro-support
> 
>  test/tarantool-debugger-tests/debug-extension-tests.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
> index 895171a4..ab44121c 100644
> --- a/test/tarantool-debugger-tests/debug-extension-tests.py
> +++ b/test/tarantool-debugger-tests/debug-extension-tests.py
> @@ -172,7 +172,7 @@ class TestCaseBase(unittest.TestCase):
>  def check_macro_debug_info():
>      cmd_file = persist('\n'.join([
>          'b lj_cf_print',
> -        *PROCESS_RUN,
> +        PROCESS_RUN,
>          'n',
>          'p gcval(L->base)',
>          'q',
> -- 
> 2.43.0
> 

-- 
Best regards,
Sergey Kaplun

Re: [Tarantool-patches] [PATCH luajit] test: fix checking macro support in dbg tests

[Mikhail Elhimov via Tarantool-patches]

Hi, Sergey!

Thanks for the review!

Please, see comments below.

On 14.09.2026 11:38, Sergey Kaplun wrote:
> Hi, Mikhail!
> Thanks for the patch!
> Honestly, I don't understand what problem it solves. Could you please
> add a more verbose commit message?

Done

> On 09.09.26, Mikhail Elhimov wrote:
>> follow-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b
>> ---
>> Branch: https://github.com/tarantool/luajit/tree/elhimov/gh-noticket-test-dbg-fix-checking-macro-support
>>
>>   test/tarantool-debugger-tests/debug-extension-tests.py | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
>> index 895171a4..ab44121c 100644
>> --- a/test/tarantool-debugger-tests/debug-extension-tests.py
>> +++ b/test/tarantool-debugger-tests/debug-extension-tests.py
>> @@ -172,7 +172,7 @@ class TestCaseBase(unittest.TestCase):
>>   def check_macro_debug_info():
>>       cmd_file = persist('\n'.join([
>>           'b lj_cf_print',
>> -        *PROCESS_RUN,
>> +        PROCESS_RUN,
>>           'n',
>>           'p gcval(L->base)',
>>           'q',
>> -- 
>> 2.43.0
>>
-- 
Best regards,
Mikhail Elhimov

[Tarantool-patches] [PATCH luajit v2] test: fix checking macro support in dbg tests

[Mikhail Elhimov via Tarantool-patches]

follow-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b

This patch fixes the mistake that was made initially. PROCESS_RUN is a
string and unpack operator should not be applied to it because beeing
applied to string it produces the sequence of the characters which is
finally transformed into the unexpected sequence of one-character
debugger's commands that don't make any sense.
---
Changes in v2:
  - Added more verbose description in commit message

Branch: https://github.com/tarantool/luajit/tree/elhimov/gh-noticket-test-dbg-fix-checking-macro-support

 test/tarantool-debugger-tests/debug-extension-tests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
index 895171a4..ab44121c 100644
--- a/test/tarantool-debugger-tests/debug-extension-tests.py
+++ b/test/tarantool-debugger-tests/debug-extension-tests.py
@@ -172,7 +172,7 @@ class TestCaseBase(unittest.TestCase):
 def check_macro_debug_info():
     cmd_file = persist('\n'.join([
         'b lj_cf_print',
-        *PROCESS_RUN,
+        PROCESS_RUN,
         'n',
         'p gcval(L->base)',
         'q',
-- 
2.43.0