Re: [Tarantool-patches] [PATCH luajit] test: fix checking macro support in dbg tests

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Mikhail!
Thanks for the clarification!
LGTM, with minor nits regarding the commit message.

On 16.09.26, Mikhail Elhimov wrote:
> Hi, Sergey!
> 
> Thanks for the review!
> 
> Please, see comments below.
> 
> On 14.09.2026 11:38, Sergey Kaplun wrote:
> > Hi, Mikhail!
> > Thanks for the patch!
> > Honestly, I don't understand what problem it solves. Could you please
> > add a more verbose commit message?
> 
> Done
> 
> > On 09.09.26, Mikhail Elhimov wrote:

> follow-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b

Minor: Please, use the following form:

| Follows-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b ("dbg: introduce
| lj-gco command").

>
> This patch fixes the mistake that was made initially. PROCESS_RUN is a
> string and unpack operator should not be applied to it because beeing

Typo: s/string/string,/
Typo: s/unpack/the unpack/
Typo: s/beeing/being/

> applied to string it produces the sequence of the characters which is

Typo: s/string/a string,/
Typo: s/characters/characters,/

> finally transformed into the unexpected sequence of one-character
> debugger's commands that don't make any sense.

> >> ---
> >> Branch: https://github.com/tarantool/luajit/tree/elhimov/gh-noticket-test-dbg-fix-checking-macro-support
> >>

<snipped>

> -- 
> Best regards,
> Mikhail Elhimov
> 

-- 
Best regards,
Sergey Kaplun