Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Mikhail Elhimov <m.elhimov@vk.team>,
	Sergey Kaplun <skaplun@tarantool.org>,
	Evgeniy Temirgaleev <e.temirgaleev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: fix checking macro support in dbg tests
Date: Mon, 28 Sep 2026 16:31:03 +0300	[thread overview]
Message-ID: <bd355222-f62b-411d-b42b-cd0e1ab7e202@tarantool.org> (raw)
In-Reply-To: <20260915232903.226904-1-m.elhimov@vk.team>

Hi, Mikhail,

thanks for the patch! LGTM

Sergey

On 9/16/26 02:29, Mikhail Elhimov wrote:
> follow-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b
>
> This patch fixes the mistake that was made initially. PROCESS_RUN is a
> string and unpack operator should not be applied to it because beeing
> applied to string it produces the sequence of the characters which is
> finally transformed into the unexpected sequence of one-character
> debugger's commands that don't make any sense.
> ---
> Changes in v2:
>    - Added more verbose description in commit message
>
> Branch: https://github.com/tarantool/luajit/tree/elhimov/gh-noticket-test-dbg-fix-checking-macro-support
>
>   test/tarantool-debugger-tests/debug-extension-tests.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
> index 895171a4..ab44121c 100644
> --- a/test/tarantool-debugger-tests/debug-extension-tests.py
> +++ b/test/tarantool-debugger-tests/debug-extension-tests.py
> @@ -172,7 +172,7 @@ class TestCaseBase(unittest.TestCase):
>   def check_macro_debug_info():
>       cmd_file = persist('\n'.join([
>           'b lj_cf_print',
> -        *PROCESS_RUN,
> +        PROCESS_RUN,
>           'n',
>           'p gcval(L->base)',
>           'q',

      reply	other threads:[~2026-09-28 13:31 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 21:50 [Tarantool-patches] [PATCH luajit] " Mikhail Elhimov via Tarantool-patches
2026-09-14  8:38 ` Sergey Kaplun via Tarantool-patches
2026-09-15 23:06   ` Mikhail Elhimov via Tarantool-patches
2026-09-18 14:48     ` Sergey Kaplun via Tarantool-patches
2026-09-18 15:17       ` [Tarantool-patches] [PATCH luajit v2] " Mikhail Elhimov via Tarantool-patches
2026-09-15 23:29 ` Mikhail Elhimov via Tarantool-patches
2026-09-28 13:31   ` Sergey Bronnikov via Tarantool-patches [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd355222-f62b-411d-b42b-cd0e1ab7e202@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=e.temirgaleev@tarantool.org \
    --cc=m.elhimov@vk.team \
    --cc=sergeyb@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit v2] test: fix checking macro support in dbg tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox