Tarantool development patches archive
 help / color / mirror / Atom feed
From: Mikhail Elhimov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix checking macro support in dbg tests
Date: Wed, 16 Sep 2026 02:06:37 +0300	[thread overview]
Message-ID: <c9d85162-439c-40f0-965d-6ab1d3641c65@vk.team> (raw)
In-Reply-To: <aqeyilWFvuWG9VAK@root>

Hi, Sergey!

Thanks for the review!

Please, see comments below.

On 14.09.2026 11:38, Sergey Kaplun wrote:
> Hi, Mikhail!
> Thanks for the patch!
> Honestly, I don't understand what problem it solves. Could you please
> add a more verbose commit message?

Done

> On 09.09.26, Mikhail Elhimov wrote:
>> follow-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b
>> ---
>> Branch: https://github.com/tarantool/luajit/tree/elhimov/gh-noticket-test-dbg-fix-checking-macro-support
>>
>>   test/tarantool-debugger-tests/debug-extension-tests.py | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/test/tarantool-debugger-tests/debug-extension-tests.py b/test/tarantool-debugger-tests/debug-extension-tests.py
>> index 895171a4..ab44121c 100644
>> --- a/test/tarantool-debugger-tests/debug-extension-tests.py
>> +++ b/test/tarantool-debugger-tests/debug-extension-tests.py
>> @@ -172,7 +172,7 @@ class TestCaseBase(unittest.TestCase):
>>   def check_macro_debug_info():
>>       cmd_file = persist('\n'.join([
>>           'b lj_cf_print',
>> -        *PROCESS_RUN,
>> +        PROCESS_RUN,
>>           'n',
>>           'p gcval(L->base)',
>>           'q',
>> -- 
>> 2.43.0
>>
-- 
Best regards,
Mikhail Elhimov


  reply	other threads:[~2026-09-15 23:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 21:50 Mikhail Elhimov via Tarantool-patches
2026-09-14  8:38 ` Sergey Kaplun via Tarantool-patches
2026-09-15 23:06   ` Mikhail Elhimov via Tarantool-patches [this message]
2026-09-15 23:29 ` [Tarantool-patches] [PATCH luajit v2] " Mikhail Elhimov via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9d85162-439c-40f0-965d-6ab1d3641c65@vk.team \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=m.elhimov@vk.team \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit] test: fix checking macro support in dbg tests' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox