From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 10A826ECED; Fri, 18 Sep 2026 17:49:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 10A826ECED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1789742956; bh=UTXDEONmXw5f6J3/AGIsdI9htAA6n+uGtDgEh6IQBEc=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=d1h7QbHbdUN5y9ko6jxb11lf7Qs1SKv095zlFlU7AQiCst+C5T2tCjX6nc4Ie622+ XsaxgEMdtWUiAT1dRWv/yTxvmLj3WY6N76cMN8OiVGyxEFA5RZbqKYO52T69AHf0CL sriEJfN8UPDET1IqP5jwMulWLxUbpcx3HRyN9Bdo= Received: from send106.i.mail.ru (send106.i.mail.ru [89.221.237.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4A9E86ECED for ; Fri, 18 Sep 2026 17:49:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 4A9E86ECED Received: by exim-smtp-759f5f99bf-c4hvt with esmtpa (envelope-from ) id 1x7Zto-0000000085T-1Gvj; Fri, 18 Sep 2026 17:49:12 +0300 Date: Fri, 18 Sep 2026 17:48:53 +0300 To: Mikhail Elhimov Message-ID: References: <20260908215018.343604-1-m.elhimov@vk.team> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-618D5548: 32F844ECEF37930AC7A4B249DE6549FDCD1D57BAD1C483626935182FDE6D3BA283E664458048807B X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD964331FA9A592EAE9917A82D711368E75D2320DFBEFF1CDB8182A05F53808504094D93362A8AA970D3DE06ABAFEAF6705F73316220F1B4CE84ECB3DBE88BA179BD99768D11C0F8B71 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE75DF2B1F23425CAE5EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756680FCA32AD7D0ED4ED7531AAA82967C58F815819E5ECA2A61838D511FB8C5026E389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B652D31B9D28593E51CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7742996B5449390BC731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A5AD891EE75279DF9B5002B1117B3ED6960AA5A8309E4C9315108A05421C070DB8823CB91A9FED034534781492E4B8EEADC24E78AA85F86F6CBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADB58128AB1E6D661A8E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659AF623D7870E845B06CF4B8B8A5CB653941E676648D482077A0C7820B52EDD3490ACFDE33EC9756D7B8341EE9D5BE9A0A8F4A45D4CB94FE77ABC0871A3F14B128AAC4A0B98B922F55C7CEAA0681F5848F4C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWL0G68x1y+rADLEd9SnCO68= X-Mailru-Sender: 689FA8AB762F73937C9FA53A4753B313CFADDE72868369F82D3E1915179C43952CCE86BA7B68512FE49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix checking macro support in dbg tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Mikhail! Thanks for the clarification! LGTM, with minor nits regarding the commit message. On 16.09.26, Mikhail Elhimov wrote: > Hi, Sergey! > > Thanks for the review! > > Please, see comments below. > > On 14.09.2026 11:38, Sergey Kaplun wrote: > > Hi, Mikhail! > > Thanks for the patch! > > Honestly, I don't understand what problem it solves. Could you please > > add a more verbose commit message? > > Done > > > On 09.09.26, Mikhail Elhimov wrote: > follow-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b Minor: Please, use the following form: | Follows-up 7b919c0c0cc5089dc4a61511a502a9ab46c72a2b ("dbg: introduce | lj-gco command"). > > This patch fixes the mistake that was made initially. PROCESS_RUN is a > string and unpack operator should not be applied to it because beeing Typo: s/string/string,/ Typo: s/unpack/the unpack/ Typo: s/beeing/being/ > applied to string it produces the sequence of the characters which is Typo: s/string/a string,/ Typo: s/characters/characters,/ > finally transformed into the unexpected sequence of one-character > debugger's commands that don't make any sense. > >> --- > >> Branch: https://github.com/tarantool/luajit/tree/elhimov/gh-noticket-test-dbg-fix-checking-macro-support > >> > -- > Best regards, > Mikhail Elhimov > -- Best regards, Sergey Kaplun