From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Serge Petrenko <sergepetrenko@tarantool.org>, gorcunov@gmail.com
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH v3 05/10] box: write PROMOTE even for empty limbo
Date: Fri, 16 Apr 2021 01:21:17 +0200 [thread overview]
Message-ID: <fe8d6150-6ad4-c152-06c2-00d35d633c13@tarantool.org> (raw)
In-Reply-To: <486f83c475f51cd3e05edabfb56c567cd85a50ad.1618409665.git.sergepetrenko@tarantool.org>
Thanks for the patch!
> @@ -1540,11 +1542,10 @@ box_clear_synchro_queue(bool try_wait)
> * in the limbo must've come through the applier meaning they already
> * have an lsn assigned, even if their WAL write hasn't finished yet.
> */
> - int64_t wait_lsn = txn_limbo_last_synchro_entry(&txn_limbo)->lsn;
> + wait_lsn = txn_limbo_last_synchro_entry(&txn_limbo)->lsn;
> assert(wait_lsn > 0);
>
> - int quorum = replication_synchro_quorum;
> - int rc = box_wait_quorum(former_leader_id, wait_lsn, quorum,
> + rc = box_wait_quorum(former_leader_id, wait_lsn, quorum,
> replication_synchro_timeout);
The second line became misaligned.
next prev parent reply other threads:[~2021-04-15 23:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-14 14:17 [Tarantool-patches] [PATCH v3 00/10] raft: introduce manual elections and fix a bug with re-applying rolled back transactions Serge Petrenko via Tarantool-patches
2021-04-14 14:17 ` [Tarantool-patches] [PATCH v3 01/10] wal: enrich row's meta information with sync replication flags Serge Petrenko via Tarantool-patches
2021-04-15 23:18 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-16 7:08 ` Serge Petrenko via Tarantool-patches
2021-04-16 7:11 ` Serge Petrenko via Tarantool-patches
2021-04-16 8:57 ` Serge Petrenko via Tarantool-patches
2021-04-14 14:17 ` [Tarantool-patches] [PATCH v3 02/10] xrow: introduce a PROMOTE entry Serge Petrenko via Tarantool-patches
2021-04-15 23:19 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-16 16:18 ` Serge Petrenko via Tarantool-patches
2021-04-14 14:17 ` [Tarantool-patches] [PATCH v3 03/10] box: actualise iproto_key_type array Serge Petrenko via Tarantool-patches
2021-04-14 14:17 ` [Tarantool-patches] [PATCH v3 04/10] box: make clear_synchro_queue() write a PROMOTE entry instead of CONFIRM + ROLLBACK Serge Petrenko via Tarantool-patches
2021-04-15 23:20 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-16 9:28 ` Serge Petrenko via Tarantool-patches
2021-04-16 14:03 ` Serge Petrenko via Tarantool-patches
2021-04-14 14:17 ` [Tarantool-patches] [PATCH v3 05/10] box: write PROMOTE even for empty limbo Serge Petrenko via Tarantool-patches
2021-04-15 23:21 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-04-16 9:33 ` Serge Petrenko via Tarantool-patches
2021-04-14 14:17 ` [Tarantool-patches] [PATCH v3 06/10] raft: keep track of greatest known term and filter replication sources based on that Serge Petrenko via Tarantool-patches
2021-04-15 23:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-16 14:16 ` Serge Petrenko via Tarantool-patches
2021-04-16 22:13 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-14 14:17 ` [Tarantool-patches] [PATCH v3 07/10] replication: introduce a new election mode: "manual" Serge Petrenko via Tarantool-patches
2021-04-15 23:27 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-16 14:18 ` Serge Petrenko via Tarantool-patches
2021-04-14 14:17 ` [Tarantool-patches] [PATCH v3 08/10] Support manual elections in `box.ctl.clear_synchro_queue()` Serge Petrenko via Tarantool-patches
2021-04-15 23:30 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-16 15:38 ` Serge Petrenko via Tarantool-patches
2021-04-16 15:40 ` Serge Petrenko via Tarantool-patches
2021-04-16 15:50 ` Serge Petrenko via Tarantool-patches
2021-04-14 14:17 ` [Tarantool-patches] [PATCH v3 09/10] box: remove parameter from clear_synchro_queue Serge Petrenko via Tarantool-patches
2021-04-14 14:18 ` [Tarantool-patches] [PATCH v3 10/10] box.ctl: rename clear_synchro_queue to promote Serge Petrenko via Tarantool-patches
2021-04-15 23:31 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-16 16:13 ` Serge Petrenko via Tarantool-patches
2021-04-14 18:21 ` [Tarantool-patches] [PATCH v3 00/10] raft: introduce manual elections and fix a bug with re-applying rolled back transactions Cyrill Gorcunov via Tarantool-patches
2021-04-15 23:16 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-16 16:35 ` Serge Petrenko via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fe8d6150-6ad4-c152-06c2-00d35d633c13@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v3 05/10] box: write PROMOTE even for empty limbo' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox