From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6F0576FC8F; Fri, 16 Apr 2021 02:21:21 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6F0576FC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618528881; bh=qFdRRphktsdLnDe8OQu5UESckBuF2C/WdTwa+/+cGUc=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=DhBUlIQl/UAd0o48HRrlZJCX52L4b7WM6ius2JSfU8xa9S+YazKKa7/wtuk7Ts05p YsY6jBf/IuFi6Ky8/we1c4sx/j3T9iujm2bJKgt5YICdud0cxnlfWXc7oD5a9lQRBa GPHjXaTzi/QOrfQ1S+Y6cr93rosOdrmyPWmths7M= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C70316FC8F for ; Fri, 16 Apr 2021 02:21:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C70316FC8F Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1lXBIU-0000zN-6x; Fri, 16 Apr 2021 02:21:18 +0300 To: Serge Petrenko , gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org References: <486f83c475f51cd3e05edabfb56c567cd85a50ad.1618409665.git.sergepetrenko@tarantool.org> Message-ID: Date: Fri, 16 Apr 2021 01:21:17 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <486f83c475f51cd3e05edabfb56c567cd85a50ad.1618409665.git.sergepetrenko@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480B1C8842CE613979723F2FB4628545A35182A05F538085040AD7DF52B1558432F6ED946FD518BCD12F1B8A252951FEA46494E7F703C660093 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FBB2043146276655EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E1D2769089B3DFB28638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B28BD037DDB489DD98F0804420396B3FD29414A38D98B987DBD2E47CDBA5A96583C09775C1D3CA48CFCF36E64A7E3F8E58117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7A3E989B1926288338941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD2691661749BA6B97735A7393995429B98667B076A6E789B0E97A8DF7F3B2552694A1E7802607F20496D49FD398EE364050FB28585415E75ADA9E7815D572A9D6896B3661434B16C20AC78D18283394535A9E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6AC294AFEFA671E80089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C978315DCA80CF9242B21657D12FD7D753A721 X-C1DE0DAB: 0D63561A33F958A51319BB9DEBBA42510DCFE8C8D17D1627344FE3E011773FD5D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34197948450CB5442A38DC24CF846F0F2C25A213BCF4BD750627177A6DA5AC4890838AA9F4778AF4C01D7E09C32AA3244CD86F5BB8789ADC10C6F8A5D85A9C1451F26BFA4C8A6946B8FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3S6P1v0GIqSJOiRyWsVUAQ== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA31105F7B22EE293FF2D1DE334C06A1A957CEB8F38F170EB25BFC07784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v3 05/10] box: write PROMOTE even for empty limbo X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > @@ -1540,11 +1542,10 @@ box_clear_synchro_queue(bool try_wait) > * in the limbo must've come through the applier meaning they already > * have an lsn assigned, even if their WAL write hasn't finished yet. > */ > - int64_t wait_lsn = txn_limbo_last_synchro_entry(&txn_limbo)->lsn; > + wait_lsn = txn_limbo_last_synchro_entry(&txn_limbo)->lsn; > assert(wait_lsn > 0); > > - int quorum = replication_synchro_quorum; > - int rc = box_wait_quorum(former_leader_id, wait_lsn, quorum, > + rc = box_wait_quorum(former_leader_id, wait_lsn, quorum, > replication_synchro_timeout); The second line became misaligned.