From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 2/8] test: introduce MakeLuaPath.cmake helper
Date: Fri, 2 Sep 2022 15:09:42 +0300 [thread overview]
Message-ID: <d6261640-1474-73d7-1f2d-6820530c9791@tarantool.org> (raw)
In-Reply-To: <Yw95Ku9zjDZsPs2P@tarantool.org>
LGTM
On 31.08.2022 18:07, Igor Munkin wrote:
> Sergey,
>
> Thanks for you review!
>
> On 15.08.22, Sergey Bronnikov wrote:
>> Igor, thanks for the patch! See my comments inline.
>>
>> On 11.08.2022 14:17, Igor Munkin wrote:
>>> While extending test suites it is often required to append additional
>>> path where Lua or Lua-C auxiliary modules are located to LUA_PATH or
>>> LUA_CPATH environment variables. Due to insane semicolon interpolation
>>> in CMake strings (that converts such string to a list as a result), we
>>> need to escape semicolon in LUA_PATH/LUA_CPATH strings while building
>>> the resulting value.
>>>
>>> After the years of struggling MakeLuaPath.cmake module is introduced to
>>> make LUA_PATH and LUA_CPATH definition convenient with <make_lua_path>
>>> helper. This function takes all paths given as a variable list argument,
>>> joins them in a reverse order by a semicolon and yields the resulting
>>> string to a specified CMake variable.
>>>
>>> Signed-off-by: Igor Munkin<imun@tarantool.org>
>>> ---
>>> cmake/MakeLuaPath.cmake | 46 +++++++++++++++++++++++
>>> test/CMakeLists.txt | 2 +
>>> test/PUC-Rio-Lua-5.1-tests/CMakeLists.txt | 8 +++-
>>> test/lua-Harness-tests/CMakeLists.txt | 16 +++++---
>>> test/tarantool-tests/CMakeLists.txt | 28 ++++++++------
>>> 5 files changed, 81 insertions(+), 19 deletions(-)
>>> create mode 100644 cmake/MakeLuaPath.cmake
>>>
>>> diff --git a/cmake/MakeLuaPath.cmake b/cmake/MakeLuaPath.cmake
>>> new file mode 100644
>>> index 00000000..9a5a3bb8
>>> --- /dev/null
>>> +++ b/cmake/MakeLuaPath.cmake
> <snipped>
>
>>> +
>>> + # FIXME: if we update to CMake >= 3.5, can remove this line.
>> I would replace comment with condition that will check CMake version
>>
>> and will fail when CMake >= 3.5:
>>
>> |if (CMAKE_VERSION VERSION_GREATER_EQUAL 35) |
>>
>> message(FATAL_ERROR "Please remove snippet for CMake < 3.5")
>>
>> endif()
> I doubt this is a working solution. The comment means, that there is no
> need to include a separate module if CMake to be used is greater than
> 3.5. With your code, fatal error is raised in that case. I have CMake
> 3.20 on my local machine and LuaJIT fails to be built with your check
> added (I've fixed the typo in the version number).
>
> Ignoring for now.
>
>>
>>> + include(CMakeParseArguments)
> <snipped>
>
next prev parent reply other threads:[~2022-09-02 12:09 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 11:17 [Tarantool-patches] [PATCH luajit 0/8] LuaJIT tests and CI enhancements Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 1/8] test: introduce LUAJIT_TEST_VARDIR variable Igor Munkin via Tarantool-patches
2022-08-15 12:08 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 8:27 ` Sergey Kaplun via Tarantool-patches
2022-08-31 14:53 ` Igor Munkin via Tarantool-patches
2022-09-02 12:06 ` Sergey Bronnikov via Tarantool-patches
2022-10-05 19:51 ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 2/8] test: introduce MakeLuaPath.cmake helper Igor Munkin via Tarantool-patches
2022-08-15 12:08 ` Sergey Bronnikov via Tarantool-patches
2022-08-31 15:07 ` Igor Munkin via Tarantool-patches
2022-09-02 12:09 ` Sergey Bronnikov via Tarantool-patches [this message]
2022-08-18 9:37 ` Sergey Kaplun via Tarantool-patches
2022-08-31 15:19 ` Igor Munkin via Tarantool-patches
2022-09-01 10:16 ` Sergey Kaplun via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 3/8] test: fix tarantool suite for out of source build Igor Munkin via Tarantool-patches
2022-08-15 12:10 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 9:49 ` Sergey Kaplun via Tarantool-patches
2022-08-31 17:20 ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions Igor Munkin via Tarantool-patches
2022-08-15 12:13 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 9:58 ` Sergey Kaplun via Tarantool-patches
2022-08-31 15:34 ` Igor Munkin via Tarantool-patches
2022-08-31 15:33 ` Igor Munkin via Tarantool-patches
2022-09-02 12:09 ` Sergey Bronnikov via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 5/8] ci: remove excess parallel level setup Igor Munkin via Tarantool-patches
2022-08-15 12:14 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:09 ` Sergey Kaplun via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 6/8] ci: remove arch prefix for macOS M1 workflow Igor Munkin via Tarantool-patches
2022-08-15 12:17 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:14 ` Sergey Kaplun via Tarantool-patches
2022-08-31 15:55 ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 7/8] ci: merge x86_64 and ARM64 workflows Igor Munkin via Tarantool-patches
2022-08-15 12:22 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:21 ` Sergey Kaplun via Tarantool-patches
2022-08-31 16:02 ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 8/8] ci: merge Linux and macOS workflows Igor Munkin via Tarantool-patches
2022-08-15 12:27 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:32 ` Sergey Kaplun via Tarantool-patches
2022-11-11 8:56 ` [Tarantool-patches] [PATCH luajit 0/8] LuaJIT tests and CI enhancements Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6261640-1474-73d7-1f2d-6820530c9791@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=sergeyb@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 2/8] test: introduce MakeLuaPath.cmake helper' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox