Tarantool development patches archive
 help / color / mirror / Atom feed
From: Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions
Date: Wed, 31 Aug 2022 18:34:39 +0300	[thread overview]
Message-ID: <Yw9/jxBZrXtH+IKS@tarantool.org> (raw)
In-Reply-To: <Yv4NS9hiBHQ31mCr@root>

Sergey,

Thanks for your review!

On 18.08.22, Sergey Kaplun wrote:
> Hi, Igor!
> 
> Thanks for the patch!
> 
> LGTM in general, but have the same question as Sergey.
> 
> On 15.08.22, Sergey Bronnikov wrote:
> > Igor, please see my comment below.
> > 
> > On 11.08.2022 14:17, Igor Munkin wrote:
> > > Use out of source build configuration for LuaJIT testing jobs in all
> > > GitHub workflows. For this build type configuration unique subdirectory
> > > (using GitHub run ID) within runner temporary directory is used as a
> > > binary artefacts tree.
> > >
> > > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > > ---
> > >   .github/actions/environment/action.yml   | 5 +++++
> > >   .github/workflows/lint.yml               | 3 ++-
> > >   .github/workflows/linux-aarch64.yml      | 6 +++++-
> > >   .github/workflows/linux-x86_64-ninja.yml | 6 +++++-
> > >   .github/workflows/linux-x86_64.yml       | 7 ++++++-
> > >   .github/workflows/macos-m1.yml           | 6 +++++-
> > >   .github/workflows/macos-x86_64.yml       | 7 ++++++-
> > >   7 files changed, 34 insertions(+), 6 deletions(-)
> > >

<snipped>

> > > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml
> > > index 8c8dcff1..21d86764 100644
> > > --- a/.github/workflows/linux-aarch64.yml
> > > +++ b/.github/workflows/linux-aarch64.yml
> > > @@ -53,11 +53,15 @@ jobs:
> > >             sudo apt -y update
> > >             sudo apt -y install cmake gcc make perl
> > >         - name: configure
> > > -        run: cmake . ${{ matrix.CMAKEFLAGS }}
> > > +        run: >
> > > +          cmake -S . -B ${{ env.BUILDDIR }}
> > > +          ${{ matrix.CMAKEFLAGS }}
> > >         - name: build
> > >           run: cmake --build . --parallel
> > > +        working-directory: ${{ env.BUILDDIR }}
> > >         - name: test
> > >           run: cmake --build . --parallel --target test
> > > +        working-directory: ${{ env.BUILDDIR }}
> > 
> > 1. I don't get an idea to use current dir for CMake and specify a 
> > working-directory in a job step.
> > 
> > Why not "cmake --build ${{ env.BUILDDIR }}" as above?
> 
> I don't get the idea too :).

I've answered to Sergey's thread.

> 

<snipped>

> 
> -- 
> Best regards,
> Sergey Kaplun

-- 
Best regards,
IM

  reply	other threads:[~2022-08-31 15:44 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 11:17 [Tarantool-patches] [PATCH luajit 0/8] LuaJIT tests and CI enhancements Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 1/8] test: introduce LUAJIT_TEST_VARDIR variable Igor Munkin via Tarantool-patches
2022-08-15 12:08   ` Sergey Bronnikov via Tarantool-patches
2022-08-18  8:27     ` Sergey Kaplun via Tarantool-patches
2022-08-31 14:53     ` Igor Munkin via Tarantool-patches
2022-09-02 12:06       ` Sergey Bronnikov via Tarantool-patches
2022-10-05 19:51         ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 2/8] test: introduce MakeLuaPath.cmake helper Igor Munkin via Tarantool-patches
2022-08-15 12:08   ` Sergey Bronnikov via Tarantool-patches
2022-08-31 15:07     ` Igor Munkin via Tarantool-patches
2022-09-02 12:09       ` Sergey Bronnikov via Tarantool-patches
2022-08-18  9:37   ` Sergey Kaplun via Tarantool-patches
2022-08-31 15:19     ` Igor Munkin via Tarantool-patches
2022-09-01 10:16       ` Sergey Kaplun via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 3/8] test: fix tarantool suite for out of source build Igor Munkin via Tarantool-patches
2022-08-15 12:10   ` Sergey Bronnikov via Tarantool-patches
2022-08-18  9:49   ` Sergey Kaplun via Tarantool-patches
2022-08-31 17:20     ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions Igor Munkin via Tarantool-patches
2022-08-15 12:13   ` Sergey Bronnikov via Tarantool-patches
2022-08-18  9:58     ` Sergey Kaplun via Tarantool-patches
2022-08-31 15:34       ` Igor Munkin via Tarantool-patches [this message]
2022-08-31 15:33     ` Igor Munkin via Tarantool-patches
2022-09-02 12:09       ` Sergey Bronnikov via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 5/8] ci: remove excess parallel level setup Igor Munkin via Tarantool-patches
2022-08-15 12:14   ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:09   ` Sergey Kaplun via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 6/8] ci: remove arch prefix for macOS M1 workflow Igor Munkin via Tarantool-patches
2022-08-15 12:17   ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:14   ` Sergey Kaplun via Tarantool-patches
2022-08-31 15:55     ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 7/8] ci: merge x86_64 and ARM64 workflows Igor Munkin via Tarantool-patches
2022-08-15 12:22   ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:21   ` Sergey Kaplun via Tarantool-patches
2022-08-31 16:02     ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 8/8] ci: merge Linux and macOS workflows Igor Munkin via Tarantool-patches
2022-08-15 12:27   ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:32   ` Sergey Kaplun via Tarantool-patches
2022-11-11  8:56 ` [Tarantool-patches] [PATCH luajit 0/8] LuaJIT tests and CI enhancements Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yw9/jxBZrXtH+IKS@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=skaplun@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox