From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>, Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 6/8] ci: remove arch prefix for macOS M1 workflow
Date: Mon, 15 Aug 2022 15:17:04 +0300 [thread overview]
Message-ID: <3c0c42a4-3756-2eb7-5ade-f3ba2bdf05f2@tarantool.org> (raw)
In-Reply-To: <e110a8af21767b657bc8e328eba8a5a06ec1a971.1660216002.git.imun@tarantool.org>
LGTM, thanks
On 11.08.2022 14:17, Igor Munkin wrote:
> Finally self-hosted GitHub Actions runners support Apple M1 hardware. As
> a result there is no need to explicitly add `arch -arm64` prefix for all
> commands being run in scope of macOS M1 workflows.
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> .github/workflows/macos-m1.yml | 19 +++++++------------
> 1 file changed, 7 insertions(+), 12 deletions(-)
>
> diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml
> index d5b0e0f1..4e1275f7 100644
> --- a/.github/workflows/macos-m1.yml
> +++ b/.github/workflows/macos-m1.yml
> @@ -28,11 +28,6 @@ concurrency:
> format('{0}-{1}', github.workflow, github.ref) }}
> cancel-in-progress: true
>
> -env:
> - # XXX: Github Actions agent uses x86_64 simulation, so we have
> - # to explicitly make it use native environment for job steps.
> - ARCH: arch -arm64
> -
> jobs:
> test-luajit:
> runs-on: macos-11-m1
> @@ -60,21 +55,21 @@ jobs:
> # XXX: 'echo' command below is required since brew installation
> # script obliges the one to enter a newline for confirming the
> # installation via Ruby script.
> - ${ARCH} brew update ||
> - echo | ${ARCH} /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
> + brew update ||
> + echo | /usr/bin/ruby -e "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install)"
> # Try to install the packages either upgrade it to avoid of fails
> # if the package already exists with the previous version.
> - ${ARCH} brew install --force cmake gcc make perl ||
> - ${ARCH} brew upgrade cmake gcc make perl
> + brew install --force cmake gcc make perl ||
> + brew upgrade cmake gcc make perl
> - name: configure
> run: >
> - ${ARCH} cmake -S . -B ${{ env.BUILDDIR }}
> + cmake -S . -B ${{ env.BUILDDIR }}
> ${{ matrix.CMAKEFLAGS }}
> - name: build
> - run: ${ARCH} cmake --build . --parallel
> + run: cmake --build . --parallel
> working-directory: ${{ env.BUILDDIR }}
> - name: test
> - run: ${ARCH} cmake --build . --parallel --target test
> + run: cmake --build . --parallel --target test
> working-directory: ${{ env.BUILDDIR }}
>
> test-tarantool-debug-w-GC64:
next prev parent reply other threads:[~2022-08-15 12:17 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 11:17 [Tarantool-patches] [PATCH luajit 0/8] LuaJIT tests and CI enhancements Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 1/8] test: introduce LUAJIT_TEST_VARDIR variable Igor Munkin via Tarantool-patches
2022-08-15 12:08 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 8:27 ` Sergey Kaplun via Tarantool-patches
2022-08-31 14:53 ` Igor Munkin via Tarantool-patches
2022-09-02 12:06 ` Sergey Bronnikov via Tarantool-patches
2022-10-05 19:51 ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 2/8] test: introduce MakeLuaPath.cmake helper Igor Munkin via Tarantool-patches
2022-08-15 12:08 ` Sergey Bronnikov via Tarantool-patches
2022-08-31 15:07 ` Igor Munkin via Tarantool-patches
2022-09-02 12:09 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 9:37 ` Sergey Kaplun via Tarantool-patches
2022-08-31 15:19 ` Igor Munkin via Tarantool-patches
2022-09-01 10:16 ` Sergey Kaplun via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 3/8] test: fix tarantool suite for out of source build Igor Munkin via Tarantool-patches
2022-08-15 12:10 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 9:49 ` Sergey Kaplun via Tarantool-patches
2022-08-31 17:20 ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 4/8] ci: use out of source build in GitHub Actions Igor Munkin via Tarantool-patches
2022-08-15 12:13 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 9:58 ` Sergey Kaplun via Tarantool-patches
2022-08-31 15:34 ` Igor Munkin via Tarantool-patches
2022-08-31 15:33 ` Igor Munkin via Tarantool-patches
2022-09-02 12:09 ` Sergey Bronnikov via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 5/8] ci: remove excess parallel level setup Igor Munkin via Tarantool-patches
2022-08-15 12:14 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:09 ` Sergey Kaplun via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 6/8] ci: remove arch prefix for macOS M1 workflow Igor Munkin via Tarantool-patches
2022-08-15 12:17 ` Sergey Bronnikov via Tarantool-patches [this message]
2022-08-18 10:14 ` Sergey Kaplun via Tarantool-patches
2022-08-31 15:55 ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 7/8] ci: merge x86_64 and ARM64 workflows Igor Munkin via Tarantool-patches
2022-08-15 12:22 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:21 ` Sergey Kaplun via Tarantool-patches
2022-08-31 16:02 ` Igor Munkin via Tarantool-patches
2022-08-11 11:17 ` [Tarantool-patches] [PATCH luajit 8/8] ci: merge Linux and macOS workflows Igor Munkin via Tarantool-patches
2022-08-15 12:27 ` Sergey Bronnikov via Tarantool-patches
2022-08-18 10:32 ` Sergey Kaplun via Tarantool-patches
2022-11-11 8:56 ` [Tarantool-patches] [PATCH luajit 0/8] LuaJIT tests and CI enhancements Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c0c42a4-3756-2eb7-5ade-f3ba2bdf05f2@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 6/8] ci: remove arch prefix for macOS M1 workflow' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox