Tarantool development patches archive
 help / color / mirror / Atom feed
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org,
	gorcunov@gmail.com
Subject: [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write
Date: Sat, 31 Oct 2020 19:01:39 +0100	[thread overview]
Message-ID: <cover.1604166646.git.v.shpilevoy@tarantool.org> (raw)

The patchset fixes the issue with synchronous transactions
printing "too long WAL write" even when WAL write speed was fine.

The reason was the the "WAL write" time is measured at transaction
commit, which is far from the actual disk write for synchronous
transactions.

@ChangeLog
* Fixed a false-positive "too long WAL write" message for synchronous transactions.

Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5139-too-long-wal
Issue: https://github.com/tarantool/tarantool/issues/5139

Vladislav Shpilevoy (3):
  txn: rename txn_complete_async to txn_on_journal_write
  txn: split complete into success and fail paths
  txn: warn "too long WAL" on write, not on commit

 src/box/txn.c       | 127 +++++++++++++++++++++-----------------------
 src/box/txn.h       |  19 ++++---
 src/box/txn_limbo.c |  37 +++++++++----
 3 files changed, 97 insertions(+), 86 deletions(-)

-- 
2.21.1 (Apple Git-122.3)

             reply	other threads:[~2020-10-31 18:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-31 18:01 Vladislav Shpilevoy [this message]
2020-10-31 18:01 ` [Tarantool-patches] [PATCH 1/3] txn: rename txn_complete_async to txn_on_journal_write Vladislav Shpilevoy
2020-11-02 11:48   ` Cyrill Gorcunov
2020-10-31 18:01 ` [Tarantool-patches] [PATCH 2/3] txn: split complete into success and fail paths Vladislav Shpilevoy
2020-11-02 12:15   ` Cyrill Gorcunov
2020-11-02 22:39     ` Vladislav Shpilevoy
2020-10-31 18:01 ` [Tarantool-patches] [PATCH 3/3] txn: warn "too long WAL" on write, not on commit Vladislav Shpilevoy
2020-11-02 12:31   ` Cyrill Gorcunov
2020-11-03  7:36 ` [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write Serge Petrenko
2020-11-03 22:19 ` Vladislav Shpilevoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1604166646.git.v.shpilevoy@tarantool.org \
    --to=v.shpilevoy@tarantool.org \
    --cc=gorcunov@gmail.com \
    --cc=sergepetrenko@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox