From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 53BC7469719 for ; Sat, 31 Oct 2020 21:01:44 +0300 (MSK) From: Vladislav Shpilevoy Date: Sat, 31 Oct 2020 19:01:39 +0100 Message-Id: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org, gorcunov@gmail.com The patchset fixes the issue with synchronous transactions printing "too long WAL write" even when WAL write speed was fine. The reason was the the "WAL write" time is measured at transaction commit, which is far from the actual disk write for synchronous transactions. @ChangeLog * Fixed a false-positive "too long WAL write" message for synchronous transactions. Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5139-too-long-wal Issue: https://github.com/tarantool/tarantool/issues/5139 Vladislav Shpilevoy (3): txn: rename txn_complete_async to txn_on_journal_write txn: split complete into success and fail paths txn: warn "too long WAL" on write, not on commit src/box/txn.c | 127 +++++++++++++++++++++----------------------- src/box/txn.h | 19 ++++--- src/box/txn_limbo.c | 37 +++++++++---- 3 files changed, 97 insertions(+), 86 deletions(-) -- 2.21.1 (Apple Git-122.3)