From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 2/3] txn: split complete into success and fail paths
Date: Mon, 2 Nov 2020 23:39:12 +0100 [thread overview]
Message-ID: <8299e23f-0a5d-914f-b64a-0b7998f1f813@tarantool.org> (raw)
In-Reply-To: <20201102121506.GB2339@grain>
Hi! Thanks for the review!
On 02.11.2020 13:15, Cyrill Gorcunov wrote:
> On Sat, Oct 31, 2020 at 07:01:41PM +0100, Vladislav Shpilevoy wrote:
>> txn_complete used to handle all the transaction outcomes:
>> - manual rollback;
>> - error at WAL write;
>> - successful WAL write and commit;
>> - successful WAL write and wait for synchronization with replicas.
>
> Looks ok to me. Ack.
>
> Here is a diff on top of the patch I would add, but up to you, feel free to ignore.
Applied and force pushed on the branch.
next prev parent reply other threads:[~2020-11-02 22:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 18:01 [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write Vladislav Shpilevoy
2020-10-31 18:01 ` [Tarantool-patches] [PATCH 1/3] txn: rename txn_complete_async to txn_on_journal_write Vladislav Shpilevoy
2020-11-02 11:48 ` Cyrill Gorcunov
2020-10-31 18:01 ` [Tarantool-patches] [PATCH 2/3] txn: split complete into success and fail paths Vladislav Shpilevoy
2020-11-02 12:15 ` Cyrill Gorcunov
2020-11-02 22:39 ` Vladislav Shpilevoy [this message]
2020-10-31 18:01 ` [Tarantool-patches] [PATCH 3/3] txn: warn "too long WAL" on write, not on commit Vladislav Shpilevoy
2020-11-02 12:31 ` Cyrill Gorcunov
2020-11-03 7:36 ` [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write Serge Petrenko
2020-11-03 22:19 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8299e23f-0a5d-914f-b64a-0b7998f1f813@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 2/3] txn: split complete into success and fail paths' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox