Re: [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write

[Serge Petrenko <sergepetrenko@tarantool.org>]

31.10.2020 21:01, Vladislav Shpilevoy пишет:
> The patchset fixes the issue with synchronous transactions
> printing "too long WAL write" even when WAL write speed was fine.
>
> The reason was the the "WAL write" time is measured at transaction
> commit, which is far from the actual disk write for synchronous
> transactions.
>
> @ChangeLog
> * Fixed a false-positive "too long WAL write" message for synchronous transactions.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5139-too-long-wal
> Issue: https://github.com/tarantool/tarantool/issues/5139
>
> Vladislav Shpilevoy (3):
>    txn: rename txn_complete_async to txn_on_journal_write
>    txn: split complete into success and fail paths
>    txn: warn "too long WAL" on write, not on commit
>
>   src/box/txn.c       | 127 +++++++++++++++++++++-----------------------
>   src/box/txn.h       |  19 ++++---
>   src/box/txn_limbo.c |  37 +++++++++----
>   3 files changed, 97 insertions(+), 86 deletions(-)
Hi! Thanks for the patchset! LGTM.
>
-- 
Serge Petrenko