From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A66E1469719 for ; Tue, 3 Nov 2020 10:36:22 +0300 (MSK) References: From: Serge Petrenko Message-ID: <6fd35664-561e-e702-981d-1c93f0ae107e@tarantool.org> Date: Tue, 3 Nov 2020 10:36:21 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com 31.10.2020 21:01, Vladislav Shpilevoy пишет: > The patchset fixes the issue with synchronous transactions > printing "too long WAL write" even when WAL write speed was fine. > > The reason was the the "WAL write" time is measured at transaction > commit, which is far from the actual disk write for synchronous > transactions. > > @ChangeLog > * Fixed a false-positive "too long WAL write" message for synchronous transactions. > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5139-too-long-wal > Issue: https://github.com/tarantool/tarantool/issues/5139 > > Vladislav Shpilevoy (3): > txn: rename txn_complete_async to txn_on_journal_write > txn: split complete into success and fail paths > txn: warn "too long WAL" on write, not on commit > > src/box/txn.c | 127 +++++++++++++++++++++----------------------- > src/box/txn.h | 19 ++++--- > src/box/txn_limbo.c | 37 +++++++++---- > 3 files changed, 97 insertions(+), 86 deletions(-) Hi! Thanks for the patchset! LGTM. > -- Serge Petrenko