From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 1/3] txn: rename txn_complete_async to txn_on_journal_write
Date: Mon, 2 Nov 2020 14:48:01 +0300 [thread overview]
Message-ID: <20201102114801.GA2339@grain> (raw)
In-Reply-To: <b994d8b4977b1d78c64a3595d665c821b92ca626.1604166646.git.v.shpilevoy@tarantool.org>
On Sat, Oct 31, 2020 at 07:01:40PM +0100, Vladislav Shpilevoy wrote:
> The function is called only by the journal when write is finished.
>
> Besides, it may not complete the transaction. In case of
> synchronous replication it is not enough for completion. It means,
> it can't have 'complete' in its name.
>
> Also the function is never used out of txn.c, so it is removed
> from txn.h and is now static.
>
> The patch is a preparation for not spaming "too long WAL write" on
> synchronous transactions, because it is simply misleading.
>
> Part of #5139
Ack
next prev parent reply other threads:[~2020-11-02 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-31 18:01 [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write Vladislav Shpilevoy
2020-10-31 18:01 ` [Tarantool-patches] [PATCH 1/3] txn: rename txn_complete_async to txn_on_journal_write Vladislav Shpilevoy
2020-11-02 11:48 ` Cyrill Gorcunov [this message]
2020-10-31 18:01 ` [Tarantool-patches] [PATCH 2/3] txn: split complete into success and fail paths Vladislav Shpilevoy
2020-11-02 12:15 ` Cyrill Gorcunov
2020-11-02 22:39 ` Vladislav Shpilevoy
2020-10-31 18:01 ` [Tarantool-patches] [PATCH 3/3] txn: warn "too long WAL" on write, not on commit Vladislav Shpilevoy
2020-11-02 12:31 ` Cyrill Gorcunov
2020-11-03 7:36 ` [Tarantool-patches] [PATCH 0/3] Qsync too long WAL write Serge Petrenko
2020-11-03 22:19 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102114801.GA2339@grain \
--to=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 1/3] txn: rename txn_complete_async to txn_on_journal_write' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox