From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com
 [209.85.167.66])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 8F1CC469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  2 Nov 2020 14:48:04 +0300 (MSK)
Received: by mail-lf1-f66.google.com with SMTP id l2so17094230lfk.0
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 02 Nov 2020 03:48:04 -0800 (PST)
Date: Mon, 2 Nov 2020 14:48:01 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20201102114801.GA2339@grain>
References: <cover.1604166646.git.v.shpilevoy@tarantool.org>
 <b994d8b4977b1d78c64a3595d665c821b92ca626.1604166646.git.v.shpilevoy@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b994d8b4977b1d78c64a3595d665c821b92ca626.1604166646.git.v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/3] txn: rename txn_complete_async
 to txn_on_journal_write
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Sat, Oct 31, 2020 at 07:01:40PM +0100, Vladislav Shpilevoy wrote:
> The function is called only by the journal when write is finished.
> 
> Besides, it may not complete the transaction. In case of
> synchronous replication it is not enough for completion. It means,
> it can't have 'complete' in its name.
> 
> Also the function is never used out of txn.c, so it is removed
> from txn.h and is now static.
> 
> The patch is a preparation for not spaming "too long WAL write" on
> synchronous transactions, because it is simply misleading.
> 
> Part of #5139
Ack