From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 463E5469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  3 Nov 2020 01:39:15 +0300 (MSK)
References: <cover.1604166646.git.v.shpilevoy@tarantool.org>
 <07914e287ba121ab735959bcf3bfd6794c591359.1604166646.git.v.shpilevoy@tarantool.org>
 <20201102121506.GB2339@grain>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <8299e23f-0a5d-914f-b64a-0b7998f1f813@tarantool.org>
Date: Mon, 2 Nov 2020 23:39:12 +0100
MIME-Version: 1.0
In-Reply-To: <20201102121506.GB2339@grain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/3] txn: split complete into
	success and fail paths
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the review!

On 02.11.2020 13:15, Cyrill Gorcunov wrote:
> On Sat, Oct 31, 2020 at 07:01:41PM +0100, Vladislav Shpilevoy wrote:
>> txn_complete used to handle all the transaction outcomes:
>> - manual rollback;
>> - error at WAL write;
>> - successful WAL write and commit;
>> - successful WAL write and wait for synchronization with replicas.
> 
> Looks ok to me. Ack.
> 
> Here is a diff on top of the patch I would add, but up to you, feel free to ignore.

Applied and force pushed on the branch.