Re: [Tarantool-patches] [PATCH v4 4/4] crash: report crash data to the feedback server

[Vladislav Shpilevoy <v.shpilevoy@tarantool.org>]

>> I see that feedback_daemon is disabled until first box.cfg. I suggest
>> you do the same here - disable crash sending by default. Enable it
>> with first box.cfg. In your script you don't use box.cfg, so a chain
>> crash won't happen. Unless some bug will override the flag responsible
>> for crash send.
> 
> Already did in update, you should have it in your mbox.
> 
>> I also realized, that before box.cfg you don't know the URL. So if I
>> crash the process before it, I get this:
>>
>> 	SystemError curl: URL using bad/illegal format or missing URL: Invalid argument
>> 	fatal error, exiting the event loop
>>
>> This is because you try to send the dump before the crash module is
>> configured.
> 
> Updated.

The error above I checked on your branch. And it remains the same
even with the latest commit which you didn't push yet. Because the
feedback options still are not configured before box.cfg. It has
nothing to do with the recursive crash.

It means, as I said above, that you can't send a crash before
box.cfg is done. Therefore you can simply not even try if the
host is not configured yet. It solves the error message, and alongside
solves the crash chain issue. You don't need environment variables
for this.

I would suggest not to rush responding to these emails, but give it
some thought beforehand.

It is actually strange, that feedback daemon does not work before
box.cfg. We don't see any reports from tarantool instances which are
used as an application server. But it has nothing to do with your
patch anyway.