Re: [Tarantool-patches] [PATCH v4 3/4] crash: move fatal signal handling in

[Cyrill Gorcunov <gorcunov@gmail.com>]

On Sun, Dec 20, 2020 at 05:07:14PM +0100, Vladislav Shpilevoy wrote:
> > 
> > I can simply drop the comment if you dont like it.
> 
> No. I am trying to understand why one plain address matters,
> and the others are not. But now I think I understood, thanks.
> Keep the comment.

OK.

> >> commit. And this commit is not atomic. Also I know when a patch is
> >> easy to follow and easy to review. This one isn't. Because I constantly
> >> need to look for changes you did among hundreds of lines of refactoring.
> >>
> >> Please, split the independent changes into separate commits so as they
> >> could be properly reviewed and the changes could be justified in the
> >> commit messages.
> > 
> > Currently the commit is big enough because I jump into signal handling
> > in one pass. If you prefer I can split the series in more small changes.
> > Or you mean the updates over previsous series should be changes in small
> > steps as a separate commits?
> 
> No, I don't mean commits with review fixes. I mean the patch commits.
> Currently you have a patch that moves signal handling to crash.c AND it
> also changes backtrace to use a 4KB buffer instead of the static buffer.

Yes, this is my bad :-( I'm really sorry for that, Vlad! Actually I found it
only after I've sent it out. I really appreciate all your comments!

> These 2 changes (move and backtrace buffer source change) are not related.
> Therefore it is not correct to put them into 1 commit. It does not matter
> in which order you will do these 2 changes, but one should be about move
> only, and the other one about backtrace buffer update only.