From: Cyrill Gorcunov <gorcunov@gmail.com> To: tml <tarantool-patches@dev.tarantool.org> Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: [Tarantool-patches] [PATCH v4 0/4] crash: implement sending feedback Date: Thu, 10 Dec 2020 19:18:28 +0300 [thread overview] Message-ID: <20201210161832.729439-1-gorcunov@gmail.com> (raw) Our feedback daemon sends only a few portions of usage statistics. But crash dumps are pretty important for us as well, because real users may catch a way more important issues than our testing farm, it is simply impossible to cover all possible scenarios. For this sake, if crash happens we can send it to our feedback server. In this series we implement only base functionality and may extend it later. I didn't find yet a simple way to test this code anything but manually. Any comments are highly appreciated. v2: - left for internal use v3 (by Mons): - enable sending crash report by default but give an ability to disable it - use vfork when running subsequent exeutable of tarantool to send report, since plain execve won't produce local crashdump v4 (by Vlad): - move all fatal's signal handling to crash.c - export only those helpers which are really needed - update backtrace to use size as an arument - provide strlcpy if not present on the system - use static allocated buffer for report - use base64 library instead of own implmentation issue https://github.com/tarantool/tarantool/issues/5261 branch gorcunov/gh-5261-crash-report-4 Cyrill Gorcunov (4): util: introduce strlcpy helper backtrace: allow to specify destination buffer crash: move fatal signal handling in crash: report crash data to the feedback server CMakeLists.txt | 1 + src/box/lua/feedback_daemon.lua | 7 + src/box/lua/load_cfg.lua | 3 + src/exports.h | 1 + src/lib/core/CMakeLists.txt | 3 +- src/lib/core/backtrace.cc | 12 +- src/lib/core/backtrace.h | 3 + src/lib/core/crash.c | 554 ++++++++++++++++++++++++++++++++ src/lib/core/crash.h | 44 +++ src/lib/core/util.c | 14 + src/main.cc | 139 +------- src/trivia/config.h.cmake | 5 + src/trivia/util.h | 15 + test/box/admin.result | 2 + test/box/cfg.result | 4 + 15 files changed, 667 insertions(+), 140 deletions(-) create mode 100644 src/lib/core/crash.c create mode 100644 src/lib/core/crash.h base-commit: a14dad9543360c49c2cf8906a88e09271cad91b6 -- 2.26.2
next reply other threads:[~2020-12-10 16:18 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-10 16:18 Cyrill Gorcunov [this message] 2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 1/4] util: introduce strlcpy helper Cyrill Gorcunov 2020-12-11 7:34 ` Serge Petrenko 2020-12-11 7:58 ` Serge Petrenko 2020-12-11 10:04 ` Cyrill Gorcunov 2020-12-11 11:07 ` Serge Petrenko 2020-12-11 11:38 ` Cyrill Gorcunov 2020-12-14 22:54 ` Vladislav Shpilevoy 2020-12-14 22:54 ` Vladislav Shpilevoy 2020-12-15 8:47 ` Cyrill Gorcunov 2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 2/4] backtrace: allow to specify destination buffer Cyrill Gorcunov 2020-12-11 7:50 ` Serge Petrenko 2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 3/4] crash: move fatal signal handling in Cyrill Gorcunov 2020-12-11 9:31 ` Serge Petrenko 2020-12-11 10:38 ` Cyrill Gorcunov 2020-12-11 11:12 ` Serge Petrenko 2020-12-14 22:54 ` Vladislav Shpilevoy 2020-12-15 8:16 ` Cyrill Gorcunov 2020-12-20 14:48 ` Vladislav Shpilevoy 2020-12-20 15:49 ` Cyrill Gorcunov 2020-12-20 16:07 ` Vladislav Shpilevoy 2020-12-20 16:58 ` Cyrill Gorcunov 2020-12-20 15:45 ` Vladislav Shpilevoy 2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 4/4] crash: report crash data to the feedback server Cyrill Gorcunov 2020-12-11 12:57 ` Serge Petrenko 2020-12-12 16:19 ` Cyrill Gorcunov 2020-12-12 17:07 ` Cyrill Gorcunov 2020-12-14 9:41 ` Serge Petrenko 2020-12-14 22:54 ` Vladislav Shpilevoy 2020-12-16 11:16 ` Cyrill Gorcunov 2020-12-16 20:31 ` Cyrill Gorcunov 2020-12-20 15:16 ` Vladislav Shpilevoy 2020-12-20 18:26 ` Cyrill Gorcunov 2020-12-20 14:48 ` Vladislav Shpilevoy 2020-12-20 18:21 ` Cyrill Gorcunov 2020-12-20 18:41 ` Vladislav Shpilevoy 2020-12-20 19:16 ` Cyrill Gorcunov 2020-12-21 17:01 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20201210161832.729439-1-gorcunov@gmail.com \ --to=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.perepelitsa@corp.mail.ru \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v4 0/4] crash: implement sending feedback' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox