From: Serge Petrenko <sergepetrenko@tarantool.org> To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org> Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>, Vladislav Shpilevoy <v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v4 2/4] backtrace: allow to specify destination buffer Date: Fri, 11 Dec 2020 10:50:08 +0300 [thread overview] Message-ID: <5c3cf81d-aa37-1941-64b8-fa8fadfd7860@tarantool.org> (raw) In-Reply-To: <20201210161832.729439-3-gorcunov@gmail.com> 10.12.2020 19:18, Cyrill Gorcunov пишет: > This will allow to reuse this routine in crash reports. > > Part-of #5261 > > Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com> > --- LGTM. > src/lib/core/backtrace.cc | 12 ++++++------ > src/lib/core/backtrace.h | 3 +++ > 2 files changed, 9 insertions(+), 6 deletions(-) > > diff --git a/src/lib/core/backtrace.cc b/src/lib/core/backtrace.cc > index 456ce9a4d..b4048089f 100644 > --- a/src/lib/core/backtrace.cc > +++ b/src/lib/core/backtrace.cc > @@ -131,7 +131,7 @@ get_proc_name(unw_cursor_t *unw_cur, unw_word_t *offset, bool skip_cache) > } > > char * > -backtrace(void) > +backtrace(char *start, size_t size) > { > int frame_no = 0; > unw_word_t sp = 0, old_sp = 0, ip, offset; > @@ -139,10 +139,9 @@ backtrace(void) > unw_getcontext(&unw_context); > unw_cursor_t unw_cur; > unw_init_local(&unw_cur, &unw_context); > - char *backtrace_buf = (char *)static_alloc(SMALL_STATIC_SIZE); > - char *p = backtrace_buf; > - char *end = p + SMALL_STATIC_SIZE - 1; > int unw_status; > + char *p = start; > + char *end = start + size - 1; > *p = '\0'; > while ((unw_status = unw_step(&unw_cur)) > 0) { > const char *proc; > @@ -174,7 +173,7 @@ backtrace(void) > say_debug("unwinding error: %i", unw_status); > #endif > out: > - return backtrace_buf; > + return start; > } > > /* > @@ -436,7 +435,8 @@ backtrace_foreach(backtrace_cb cb, coro_context *coro_ctx, void *cb_ctx) > void > print_backtrace(void) > { > - fdprintf(STDERR_FILENO, "%s", backtrace()); > + char *start = (char *)static_alloc(SMALL_STATIC_SIZE); > + fdprintf(STDERR_FILENO, "%s", backtrace(start, SMALL_STATIC_SIZE)); > } > #endif /* ENABLE_BACKTRACE */ > > diff --git a/src/lib/core/backtrace.h b/src/lib/core/backtrace.h > index c119d5402..e0ae56be4 100644 > --- a/src/lib/core/backtrace.h > +++ b/src/lib/core/backtrace.h > @@ -40,6 +40,9 @@ extern "C" { > #ifdef ENABLE_BACKTRACE > #include <coro.h> > > +char * > +backtrace(char *start, size_t size); > + > void print_backtrace(void); > > typedef int (backtrace_cb)(int frameno, void *frameret, -- Serge Petrenko
next prev parent reply other threads:[~2020-12-11 7:50 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-10 16:18 [Tarantool-patches] [PATCH v4 0/4] crash: implement sending feedback Cyrill Gorcunov 2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 1/4] util: introduce strlcpy helper Cyrill Gorcunov 2020-12-11 7:34 ` Serge Petrenko 2020-12-11 7:58 ` Serge Petrenko 2020-12-11 10:04 ` Cyrill Gorcunov 2020-12-11 11:07 ` Serge Petrenko 2020-12-11 11:38 ` Cyrill Gorcunov 2020-12-14 22:54 ` Vladislav Shpilevoy 2020-12-14 22:54 ` Vladislav Shpilevoy 2020-12-15 8:47 ` Cyrill Gorcunov 2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 2/4] backtrace: allow to specify destination buffer Cyrill Gorcunov 2020-12-11 7:50 ` Serge Petrenko [this message] 2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 3/4] crash: move fatal signal handling in Cyrill Gorcunov 2020-12-11 9:31 ` Serge Petrenko 2020-12-11 10:38 ` Cyrill Gorcunov 2020-12-11 11:12 ` Serge Petrenko 2020-12-14 22:54 ` Vladislav Shpilevoy 2020-12-15 8:16 ` Cyrill Gorcunov 2020-12-20 14:48 ` Vladislav Shpilevoy 2020-12-20 15:49 ` Cyrill Gorcunov 2020-12-20 16:07 ` Vladislav Shpilevoy 2020-12-20 16:58 ` Cyrill Gorcunov 2020-12-20 15:45 ` Vladislav Shpilevoy 2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 4/4] crash: report crash data to the feedback server Cyrill Gorcunov 2020-12-11 12:57 ` Serge Petrenko 2020-12-12 16:19 ` Cyrill Gorcunov 2020-12-12 17:07 ` Cyrill Gorcunov 2020-12-14 9:41 ` Serge Petrenko 2020-12-14 22:54 ` Vladislav Shpilevoy 2020-12-16 11:16 ` Cyrill Gorcunov 2020-12-16 20:31 ` Cyrill Gorcunov 2020-12-20 15:16 ` Vladislav Shpilevoy 2020-12-20 18:26 ` Cyrill Gorcunov 2020-12-20 14:48 ` Vladislav Shpilevoy 2020-12-20 18:21 ` Cyrill Gorcunov 2020-12-20 18:41 ` Vladislav Shpilevoy 2020-12-20 19:16 ` Cyrill Gorcunov 2020-12-21 17:01 ` Vladislav Shpilevoy
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=5c3cf81d-aa37-1941-64b8-fa8fadfd7860@tarantool.org \ --to=sergepetrenko@tarantool.org \ --cc=gorcunov@gmail.com \ --cc=tarantool-patches@dev.tarantool.org \ --cc=v.perepelitsa@corp.mail.ru \ --cc=v.shpilevoy@tarantool.org \ --subject='Re: [Tarantool-patches] [PATCH v4 2/4] backtrace: allow to specify destination buffer' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox