From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: Mons Anderson <v.perepelitsa@corp.mail.ru>,
tml <tarantool-patches@dev.tarantool.org>,
Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v4 1/4] util: introduce strlcpy helper
Date: Fri, 11 Dec 2020 14:38:12 +0300 [thread overview]
Message-ID: <20201211113812.GE544004@grain> (raw)
In-Reply-To: <b769897d-b432-1dd2-db13-210d03e7760b@tarantool.org>
On Fri, Dec 11, 2020 at 02:07:53PM +0300, Serge Petrenko wrote:
...
> >
> > n.b. You know every time I see `if (x != [0|NULL])` statement
> > it driving me nuts: the language standart is pretty clear for
> > `if ()` statement and explains how it is evaluated and I always
> > wonder who exactly invented this explisit test for non-zero/nil?!
> > Now *every* if statement requires 5 additional symbols for simply
> > nothing :( I suspect the person who started to use this form
> > simply was not aware of the language standart.
>
> I guess it's more about code readability rather than producing a
> correct expression according to the standard.
Hardly. I suspect it was due to lack of understanding how code
compiles and evaluates, and being nonfamiliar with standarts ;)
>
> I was also surprised by this rule at first, but got used to it now.
> It's all about what you're used to, after all.
Yeah, not a big deal, I can live with this style as well and try
to follow for sure :)
next prev parent reply other threads:[~2020-12-11 11:38 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 16:18 [Tarantool-patches] [PATCH v4 0/4] crash: implement sending feedback Cyrill Gorcunov
2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 1/4] util: introduce strlcpy helper Cyrill Gorcunov
2020-12-11 7:34 ` Serge Petrenko
2020-12-11 7:58 ` Serge Petrenko
2020-12-11 10:04 ` Cyrill Gorcunov
2020-12-11 11:07 ` Serge Petrenko
2020-12-11 11:38 ` Cyrill Gorcunov [this message]
2020-12-14 22:54 ` Vladislav Shpilevoy
2020-12-14 22:54 ` Vladislav Shpilevoy
2020-12-15 8:47 ` Cyrill Gorcunov
2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 2/4] backtrace: allow to specify destination buffer Cyrill Gorcunov
2020-12-11 7:50 ` Serge Petrenko
2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 3/4] crash: move fatal signal handling in Cyrill Gorcunov
2020-12-11 9:31 ` Serge Petrenko
2020-12-11 10:38 ` Cyrill Gorcunov
2020-12-11 11:12 ` Serge Petrenko
2020-12-14 22:54 ` Vladislav Shpilevoy
2020-12-15 8:16 ` Cyrill Gorcunov
2020-12-20 14:48 ` Vladislav Shpilevoy
2020-12-20 15:49 ` Cyrill Gorcunov
2020-12-20 16:07 ` Vladislav Shpilevoy
2020-12-20 16:58 ` Cyrill Gorcunov
2020-12-20 15:45 ` Vladislav Shpilevoy
2020-12-10 16:18 ` [Tarantool-patches] [PATCH v4 4/4] crash: report crash data to the feedback server Cyrill Gorcunov
2020-12-11 12:57 ` Serge Petrenko
2020-12-12 16:19 ` Cyrill Gorcunov
2020-12-12 17:07 ` Cyrill Gorcunov
2020-12-14 9:41 ` Serge Petrenko
2020-12-14 22:54 ` Vladislav Shpilevoy
2020-12-16 11:16 ` Cyrill Gorcunov
2020-12-16 20:31 ` Cyrill Gorcunov
2020-12-20 15:16 ` Vladislav Shpilevoy
2020-12-20 18:26 ` Cyrill Gorcunov
2020-12-20 14:48 ` Vladislav Shpilevoy
2020-12-20 18:21 ` Cyrill Gorcunov
2020-12-20 18:41 ` Vladislav Shpilevoy
2020-12-20 19:16 ` Cyrill Gorcunov
2020-12-21 17:01 ` Vladislav Shpilevoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211113812.GE544004@grain \
--to=gorcunov@gmail.com \
--cc=sergepetrenko@tarantool.org \
--cc=tarantool-patches@dev.tarantool.org \
--cc=v.perepelitsa@corp.mail.ru \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH v4 1/4] util: introduce strlcpy helper' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox