Re: [Tarantool-patches] [PATCH luajit 2/5] FFI/ARM64/OSX: Handle non-standard OSX C calling conventions.

[Sergey Kaplun via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Hi, Sergey!
Thanks for the review!
Fixed your comment.

On 01.06.26, Sergey Bronnikov wrote:
> Hi, Sergey,
> 
> thanks for the patch! LGTM with two minor comments.
> 
> Sergey
> 
> On 5/30/26 19:04, Sergey Kaplun wrote:

<snipped>

> > +float test_float_stack(float f1, float f2, float f3, float f4, float f5,
> > +		       float f6, float f7, float f8, float f9, float f10,
> > +		       float f11)
> > +{
> > +	return f1 + f2 + f3 + f4 + f5 + f6 + f7 + f8 + f9 + f10 + f11;
> > +}
> > +
> newline is not needed

Removed:
===================================================================
diff --git a/test/tarantool-tests/ffi-ccall/libfficcall.c b/test/tarantool-tests/ffi-ccall/libfficcall.c
index fd2d4711..91187190 100644
--- a/test/tarantool-tests/ffi-ccall/libfficcall.c
+++ b/test/tarantool-tests/ffi-ccall/libfficcall.c
@@ -76,4 +76,3 @@ float test_float_stack(float f1, float f2, float f3, float f4, float f5,
 {
         return f1 + f2 + f3 + f4 + f5 + f6 + f7 + f8 + f9 + f10 + f11;
 }
-
===================================================================

> > diff --git a/test/tarantool-tests/gh-6097-arm64-osx-ffi-vararg.test.lua b/test/tarantool-tests/gh-6097-arm64-osx-ffi-vararg.test.lua
> > new file mode 100644
> > index 00000000..fc44d253
> > --- /dev/null
> > +++ b/test/tarantool-tests/gh-6097-arm64-osx-ffi-vararg.test.lua

<snipped>

> > +
> > +local results = {}
> > +for i = 1, 4 do
> > +  local strlen = ffi.C.sprintf(str, '%d', 1LL)
> honestly, I didn't get why the resulted buffer is named "strlen". The 
> same is below.

See `man sprintf'.

> > +  assert(strlen == EXPECTED_LEN, 'correct string length for result')

<snipped>

-- 
Best regards,
Sergey Kaplun