From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2D6C26EFDC; Thu, 4 Jun 2026 12:46:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2D6C26EFDC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1780566399; bh=eSfsttFSHX7lkTH+poNXMbahQY9JBQXnv9PQXs1c8+A=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ipi8VBMar0YeEOgmUjGCK0hFpOsPDnjPCO7T6mIT07CSCjQs/ccjWYyONvDqnWvuf Z/1Z3PARRLleOf/yoGRtbt7ZHQiwONlVciUfykfHm/yKb+LL/990I2CdUQkSbTy2Pf O86tLNLHMH5oU4v8MVQH9MWWOwqRQ+X1VSkf2k/M= Received: from send80.i.mail.ru (send80.i.mail.ru [89.221.237.175]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A5C016EFDC for ; Thu, 4 Jun 2026 12:46:37 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A5C016EFDC Received: by exim-smtp-5b85998476-n5fzt with esmtpa (envelope-from ) id 1wV4eq-00000000JNI-2pbf; Thu, 04 Jun 2026 12:46:37 +0300 Date: Thu, 4 Jun 2026 12:46:01 +0300 To: Sergey Bronnikov Message-ID: References: <20260530160409.4043089-1-skaplun@tarantool.org> <20260530160409.4043089-3-skaplun@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9FAD06046D747065B904BF8DE1504AFD90984DF84FDFE86BA182A05F53808504092F0DA9C5928CF723DE06ABAFEAF67057AE896AFD7357084736AA1911E19EC055A4E529B88FDD277 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71D16D29A965DB9EEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB5533756660A56BB7F6F20B60A8685FCBA85B9B08A2B89DAF49370813DB17C81D7CC6979D389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0A3E989B1926288338941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C39472471D10B198B935872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5AB644A9FAD98F56C5002B1117B3ED6968766E6E1EAB1F3863D2BBC1EF78EDEBE823CB91A9FED034534781492E4B8EEADF5E532225D4D775BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659CC9D88A84ADEA031B9EA912EAC13F6CE2BC387B638DD30690B8675640AC6067D1A09C766284D1B4BB8341EE9D5BE9A0A455E8C7FBC01702A4A67EF5445B38E99B50E735047CD8D6C6536EB022892E5344C41F94D744909CECFA6C6B0C050A61A8CAF69B82BA93681CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVRI2994ruhLUQf1pOLm44yM= X-DA7885C5: C2713FBEBFC29E8CF255D290C0D534F946DFEC546B5648151B9BBC6120D027C1E37C6FF933A21A8D5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE28F5B5DB205D467CEFF804835706AA6827CDD224F35AB1E35E49D44BB4BD9522A059A1ED8796F048DB274557F927329BE89D5A3BC2B10C37545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/5] FFI/ARM64/OSX: Handle non-standard OSX C calling conventions. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Kaplun via Tarantool-patches Reply-To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! Thanks for the review! Fixed your comment. On 01.06.26, Sergey Bronnikov wrote: > Hi, Sergey, > > thanks for the patch! LGTM with two minor comments. > > Sergey > > On 5/30/26 19:04, Sergey Kaplun wrote: > > +float test_float_stack(float f1, float f2, float f3, float f4, float f5, > > + float f6, float f7, float f8, float f9, float f10, > > + float f11) > > +{ > > + return f1 + f2 + f3 + f4 + f5 + f6 + f7 + f8 + f9 + f10 + f11; > > +} > > + > newline is not needed Removed: =================================================================== diff --git a/test/tarantool-tests/ffi-ccall/libfficcall.c b/test/tarantool-tests/ffi-ccall/libfficcall.c index fd2d4711..91187190 100644 --- a/test/tarantool-tests/ffi-ccall/libfficcall.c +++ b/test/tarantool-tests/ffi-ccall/libfficcall.c @@ -76,4 +76,3 @@ float test_float_stack(float f1, float f2, float f3, float f4, float f5, { return f1 + f2 + f3 + f4 + f5 + f6 + f7 + f8 + f9 + f10 + f11; } - =================================================================== > > diff --git a/test/tarantool-tests/gh-6097-arm64-osx-ffi-vararg.test.lua b/test/tarantool-tests/gh-6097-arm64-osx-ffi-vararg.test.lua > > new file mode 100644 > > index 00000000..fc44d253 > > --- /dev/null > > +++ b/test/tarantool-tests/gh-6097-arm64-osx-ffi-vararg.test.lua > > + > > +local results = {} > > +for i = 1, 4 do > > + local strlen = ffi.C.sprintf(str, '%d', 1LL) > honestly, I didn't get why the resulted buffer is named "strlen". The > same is below. See `man sprintf'. > > + assert(strlen == EXPECTED_LEN, 'correct string length for result') -- Best regards, Sergey Kaplun