Re: [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing

[Igor Munkin via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

Sergey,

Thanks for your review!

On 01.07.22, Sergey Bronnikov wrote:
> LGTM (see my comments inline).

Added your tag:
| Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>

Anyway, I've answered your comment with no fixes provided, so I postpone
the push until your explicit approvement.

> 
> 
> On 22.06.2022 18:33, Igor Munkin wrote:
> > This patch introduces additional steps with Tarantool integration
> > testing to all existing LuaJIT workflows. All steps invoke reusable
> > workflow[1] from Tarantool repository for each matrix entry being set
> > for particular LuaJIT workflow.
> >
> > [1]: https://github.com/tarantool/tarantool/blob/master/.github/workflows/luajit-integration.yml
> >
> > Signed-off-by: Igor Munkin <imun@tarantool.org>
> > ---
> >   .github/workflows/linux-aarch64.yml | 25 +++++++++++++++--
> >   .github/workflows/linux-x86_64.yml  | 43 +++++++++++++++++++++++++++--
> >   .github/workflows/macos-m1.yml      | 25 +++++++++++++++--
> >   .github/workflows/macos-x86_64.yml  | 43 +++++++++++++++++++++++++++--
> >   4 files changed, 124 insertions(+), 12 deletions(-)
> >
> > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml
> > index de360b12..293b572e 100644
> > --- a/.github/workflows/linux-aarch64.yml
> > +++ b/.github/workflows/linux-aarch64.yml
> > @@ -1,4 +1,4 @@
> > -name: "LuaJIT test workflow (Linux/aarch64)"
> > +name: "Linux/aarch64 test workflow"
> >   
> Nit: seems changes here and below with renaming jobs are not related to 
> commit.

Yes and no. I've added new steps, hence this becomes *not only* "LuaJIT
test workflow". I can move this renaming to the separate commit but
strongly doubt it worths. If it doesn't bother you a lot, I would
proceed with the patch with no changes.

> >   on:
> >     push:

<snipped>

-- 
Best regards,
IM