From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B70F46ECE3; Mon, 4 Jul 2022 10:14:20 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B70F46ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656918860; bh=q4usdXDOgy4ZLOYnxndXCY61Kwdkv0HmIh0FKy5WFrk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=dgu3gBGjCu4P9feG7nSHIn8MGMCk1aFTDzPRzYQY+aFnydtJhX1KN3FQcimXM3CqQ +PGJs0yHEx69UdyIhSJqRRIrsrhjVg/If8BCeRZLncYL9YxErlowJwgtp3NsXmK0ih DB+iZ1cXrhs+NrXngiT82LUQOQrvhNZiMy7O+sg8= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8E01C6ECE3 for ; Mon, 4 Jul 2022 10:14:19 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8E01C6ECE3 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1o8GHi-00081x-Hs; Mon, 04 Jul 2022 10:14:19 +0300 Date: Mon, 4 Jul 2022 10:07:06 +0300 To: Sergey Bronnikov Message-ID: References: <0b728799a1a9a03e008c249ed12ded71134c5bd9.1655911291.git.imun@tarantool.org> <6bee91a8-da04-5637-b0f3-181a83474061@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <6bee91a8-da04-5637-b0f3-181a83474061@tarantool.org> X-Clacks-Overhead: GNU Terry Pratchett X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD987C0EE6E7F0A597DECCDA9CADD3BE68C0D767A545FF7CB3CCD62213F67905E7A4542F676825E8FDDE7829ACDE0D537FE7546DE3D7AEAA8BEDEB93F7F06BD0150 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE728F774C865CF4B07EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FD169B9D7A3022168638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8AFDE8E7845D0E2C0F17BC65C1541BBA8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B3A703B70628EAD7BA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C2C2559B29ED8195043847C11F186F3C59DAA53EE0834AAEE X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C1CA73F2AB738EB2379C2CAF6DC8D38E13E68A1B877F66ECCAD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3433E9BC74ABA5769F5FEEEB104D336AC409C65F622A5AC95C3F8F31CEF03F1856C0F58ACAC74FDA631D7E09C32AA3244C7A7CCFFCBED1093F6DDD8152EA183883B018FE5BB746DCD1927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoR2RQGvSEnTDk4E1NDftFg== X-Mailru-Sender: 689FA8AB762F7393CC2E0F076E87284E81A6224933697937ED2098F34D68FF56A7C8D0F45F857DBFE9F1EFEE2F478337FB559BB5D741EB964C8C2C849690F8E70A04DAD6CC59E3365FEEDEB644C299C0ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Igor Munkin via Tarantool-patches Reply-To: Igor Munkin Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, Thanks for your review! On 01.07.22, Sergey Bronnikov wrote: > LGTM (see my comments inline). Added your tag: | Reviewed-by: Sergey Bronnikov Anyway, I've answered your comment with no fixes provided, so I postpone the push until your explicit approvement. > > > On 22.06.2022 18:33, Igor Munkin wrote: > > This patch introduces additional steps with Tarantool integration > > testing to all existing LuaJIT workflows. All steps invoke reusable > > workflow[1] from Tarantool repository for each matrix entry being set > > for particular LuaJIT workflow. > > > > [1]: https://github.com/tarantool/tarantool/blob/master/.github/workflows/luajit-integration.yml > > > > Signed-off-by: Igor Munkin > > --- > > .github/workflows/linux-aarch64.yml | 25 +++++++++++++++-- > > .github/workflows/linux-x86_64.yml | 43 +++++++++++++++++++++++++++-- > > .github/workflows/macos-m1.yml | 25 +++++++++++++++-- > > .github/workflows/macos-x86_64.yml | 43 +++++++++++++++++++++++++++-- > > 4 files changed, 124 insertions(+), 12 deletions(-) > > > > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml > > index de360b12..293b572e 100644 > > --- a/.github/workflows/linux-aarch64.yml > > +++ b/.github/workflows/linux-aarch64.yml > > @@ -1,4 +1,4 @@ > > -name: "LuaJIT test workflow (Linux/aarch64)" > > +name: "Linux/aarch64 test workflow" > > > Nit: seems changes here and below with renaming jobs are not related to > commit. Yes and no. I've added new steps, hence this becomes *not only* "LuaJIT test workflow". I can move this renaming to the separate commit but strongly doubt it worths. If it doesn't bother you a lot, I would proceed with the patch with no changes. > > on: > > push: -- Best regards, IM