Re: [Tarantool-patches] [PATCH luajit 2/3] ci: remove GC64 matrix entries for ARM64 workflows

[Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>]

LGTM, thanks!

On 22.06.2022 18:33, Igor Munkin wrote:
> CMake option LUAJIT_ENABLE_GC64 changes nothing for ARM64 LuaJIT builds
> (i.e. LJ_GC64 is defined on ARM64 platforms despite the value set to
> LUAJIT_ENABLE_GC64). As a result GC64 entry is removed from both Linux
> and MacOS ARM64 workflows to reduce cloud resources costs and suspend
> global warming.
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
>   .github/workflows/linux-aarch64.yml | 5 ++---
>   .github/workflows/macos-m1.yml      | 5 ++---
>   2 files changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml
> index 19412b3f..de360b12 100644
> --- a/.github/workflows/linux-aarch64.yml
> +++ b/.github/workflows/linux-aarch64.yml
> @@ -35,13 +35,12 @@ jobs:
>         fail-fast: false
>         matrix:
>           BUILDTYPE: [Debug, Release]
> -        GC64: [ON, OFF]
>           include:
>             - BUILDTYPE: Debug
>               CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
>             - BUILDTYPE: Release
>               CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
> -    name: Linux/aarch64 ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }}
> +    name: Linux/aarch64 ${{ matrix.BUILDTYPE }} GC64:ON
>       steps:
>         - uses: actions/checkout@v2.3.4
>           with:
> @@ -52,7 +51,7 @@ jobs:
>             sudo apt -y update
>             sudo apt -y install cmake gcc make perl
>         - name: configure
> -        run: cmake . ${{ matrix.CMAKEFLAGS }} -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }}
> +        run: cmake . ${{ matrix.CMAKEFLAGS }}
>         - name: build
>           run: cmake --build . --parallel $(($(nproc) + 1))
>         - name: test
> diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml
> index d1d144f0..a38f70f7 100644
> --- a/.github/workflows/macos-m1.yml
> +++ b/.github/workflows/macos-m1.yml
> @@ -40,13 +40,12 @@ jobs:
>         fail-fast: false
>         matrix:
>           BUILDTYPE: [Debug, Release]
> -        GC64: [ON, OFF]
>           include:
>             - BUILDTYPE: Debug
>               CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
>             - BUILDTYPE: Release
>               CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
> -    name: macOS/m1 ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }}
> +    name: macOS/m1 ${{ matrix.BUILDTYPE }} GC64:ON
>       steps:
>         - uses: actions/checkout@v2.3.4
>           with:
> @@ -66,7 +65,7 @@ jobs:
>             ${ARCH} brew install --force cmake gcc make perl ||
>               ${ARCH} brew upgrade cmake gcc make perl
>         - name: configure
> -        run: ${ARCH} cmake . ${{ matrix.CMAKEFLAGS }} -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }}
> +        run: ${ARCH} cmake . ${{ matrix.CMAKEFLAGS }}
>         - name: build
>           run: ${ARCH} cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1))
>         - name: test