From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A8E716ECE3; Fri, 1 Jul 2022 16:21:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A8E716ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656681668; bh=7+52eZ6od6x7zUZkttL/XT5SMIZVt1zBOWentcZpes4=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=sZrp5GiauET/wnNBGMNm+K3lwA8faI4yr84WM+GrRlt4u3Kvo5owuHZZzw/gDd9YA uIYlBkoq1hDE1BXBmu+6uGP0Srtf1DNY/FJMggCcj4jCBTLO0y8LiWToP4mLosdhdL q+npgSReYQGTVvq+S5ETCPkntT+fZRoyhk+PsEo8= Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 88F466ECE3 for ; Fri, 1 Jul 2022 16:21:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 88F466ECE3 Received: by smtp50.i.mail.ru with esmtpa (envelope-from ) id 1o7Ga2-0000af-N5; Fri, 01 Jul 2022 16:21:07 +0300 Message-ID: <90335bd3-aa26-2b42-3481-698ea8d7719f@tarantool.org> Date: Fri, 1 Jul 2022 16:21:05 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Igor Munkin , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD987C0EE6E7F0A597DECCDA9CADD3BE68C0D767A545FF7CB3CCD62213F67905E7A1E72D4D89C3EA5D6FF542CEBE890155BE9B862D4AA958EA965B98BC17AE4ABE7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70ED3881ADD6CEF6AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063761A26A2A89ED60DE8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D7BBF437A1DC321B2FA16AE493141C23117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BAA867293B0326636D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE91ADC097FE2C3A080CB8D3112395442FD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE324F796C710B8583C9735652A29929C6CC4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006372A310894EFA5E9A9EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1CFCB9B35391069A811B65401F60C7D079021FAC01DE227A32AD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34FACF503ACC83041B03A845DB7D6D77717D7F344435290F79CB5D19298050557A9AB33E1435BBE7BF1D7E09C32AA3244C9417A6C6F0F90DC29AEE15579993A17205AB220A9D022EBCFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojs3a5nOu33tzLQQ79xm52gw== X-Mailru-Sender: 0A26D9779F8DDEAB8BAA69DB2EA45A4DC5B1DDE67892AC19B0C38AA4E1FFA75E351095D289E5A425282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] ci: remove GC64 matrix entries for ARM64 workflows X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM, thanks! On 22.06.2022 18:33, Igor Munkin wrote: > CMake option LUAJIT_ENABLE_GC64 changes nothing for ARM64 LuaJIT builds > (i.e. LJ_GC64 is defined on ARM64 platforms despite the value set to > LUAJIT_ENABLE_GC64). As a result GC64 entry is removed from both Linux > and MacOS ARM64 workflows to reduce cloud resources costs and suspend > global warming. > > Signed-off-by: Igor Munkin > --- > .github/workflows/linux-aarch64.yml | 5 ++--- > .github/workflows/macos-m1.yml | 5 ++--- > 2 files changed, 4 insertions(+), 6 deletions(-) > > diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml > index 19412b3f..de360b12 100644 > --- a/.github/workflows/linux-aarch64.yml > +++ b/.github/workflows/linux-aarch64.yml > @@ -35,13 +35,12 @@ jobs: > fail-fast: false > matrix: > BUILDTYPE: [Debug, Release] > - GC64: [ON, OFF] > include: > - BUILDTYPE: Debug > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > - BUILDTYPE: Release > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > - name: Linux/aarch64 ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }} > + name: Linux/aarch64 ${{ matrix.BUILDTYPE }} GC64:ON > steps: > - uses: actions/checkout@v2.3.4 > with: > @@ -52,7 +51,7 @@ jobs: > sudo apt -y update > sudo apt -y install cmake gcc make perl > - name: configure > - run: cmake . ${{ matrix.CMAKEFLAGS }} -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }} > + run: cmake . ${{ matrix.CMAKEFLAGS }} > - name: build > run: cmake --build . --parallel $(($(nproc) + 1)) > - name: test > diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml > index d1d144f0..a38f70f7 100644 > --- a/.github/workflows/macos-m1.yml > +++ b/.github/workflows/macos-m1.yml > @@ -40,13 +40,12 @@ jobs: > fail-fast: false > matrix: > BUILDTYPE: [Debug, Release] > - GC64: [ON, OFF] > include: > - BUILDTYPE: Debug > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON > - BUILDTYPE: Release > CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo > - name: macOS/m1 ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }} > + name: macOS/m1 ${{ matrix.BUILDTYPE }} GC64:ON > steps: > - uses: actions/checkout@v2.3.4 > with: > @@ -66,7 +65,7 @@ jobs: > ${ARCH} brew install --force cmake gcc make perl || > ${ARCH} brew upgrade cmake gcc make perl > - name: configure > - run: ${ARCH} cmake . ${{ matrix.CMAKEFLAGS }} -DLUAJIT_ENABLE_GC64=${{ matrix.GC64 }} > + run: ${ARCH} cmake . ${{ matrix.CMAKEFLAGS }} > - name: build > run: ${ARCH} cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1)) > - name: test