From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>, Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing
Date: Fri, 1 Jul 2022 16:39:26 +0300 [thread overview]
Message-ID: <6bee91a8-da04-5637-b0f3-181a83474061@tarantool.org> (raw)
In-Reply-To: <0b728799a1a9a03e008c249ed12ded71134c5bd9.1655911291.git.imun@tarantool.org>
LGTM (see my comments inline).
On 22.06.2022 18:33, Igor Munkin wrote:
> This patch introduces additional steps with Tarantool integration
> testing to all existing LuaJIT workflows. All steps invoke reusable
> workflow[1] from Tarantool repository for each matrix entry being set
> for particular LuaJIT workflow.
>
> [1]: https://github.com/tarantool/tarantool/blob/master/.github/workflows/luajit-integration.yml
>
> Signed-off-by: Igor Munkin <imun@tarantool.org>
> ---
> .github/workflows/linux-aarch64.yml | 25 +++++++++++++++--
> .github/workflows/linux-x86_64.yml | 43 +++++++++++++++++++++++++++--
> .github/workflows/macos-m1.yml | 25 +++++++++++++++--
> .github/workflows/macos-x86_64.yml | 43 +++++++++++++++++++++++++++--
> 4 files changed, 124 insertions(+), 12 deletions(-)
>
> diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml
> index de360b12..293b572e 100644
> --- a/.github/workflows/linux-aarch64.yml
> +++ b/.github/workflows/linux-aarch64.yml
> @@ -1,4 +1,4 @@
> -name: "LuaJIT test workflow (Linux/aarch64)"
> +name: "Linux/aarch64 test workflow"
>
Nit: seems changes here and below with renaming jobs are not related to
commit.
> on:
> push:
> @@ -29,7 +29,7 @@ concurrency:
> cancel-in-progress: true
>
> jobs:
> - test-linux-aarch64:
> + test-luajit:
> runs-on: graviton
> strategy:
> fail-fast: false
> @@ -40,7 +40,7 @@ jobs:
> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
> - BUILDTYPE: Release
> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
> - name: Linux/aarch64 ${{ matrix.BUILDTYPE }} GC64:ON
> + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:ON
> steps:
> - uses: actions/checkout@v2.3.4
> with:
> @@ -56,3 +56,22 @@ jobs:
> run: cmake --build . --parallel $(($(nproc) + 1))
> - name: test
> run: cmake --build . --parallel $(($(nproc) + 1)) --target test
> +
> + test-tarantool-debug-w-GC64:
> + name: Tarantool Debug GC64:ON
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: ON
> + buildtype: Debug
> + host: graviton
> + revision: ${{ github.sha }}
> + test-tarantool-release-w-GC64:
> + name: Tarantool Release GC64:ON
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: ON
> + buildtype: RelWithDebInfo
> + host: graviton
> + revision: ${{ github.sha }}
> diff --git a/.github/workflows/linux-x86_64.yml b/.github/workflows/linux-x86_64.yml
> index d6434afe..3eaf436d 100644
> --- a/.github/workflows/linux-x86_64.yml
> +++ b/.github/workflows/linux-x86_64.yml
> @@ -1,4 +1,4 @@
> -name: "LuaJIT test workflow (Linux/x86_64)"
> +name: "Linux/x86_64 test workflow"
>
> on:
> push:
> @@ -29,7 +29,7 @@ concurrency:
> cancel-in-progress: true
>
> jobs:
> - test-linux-x86_64:
> + test-luajit:
> runs-on: ubuntu-20.04-self-hosted
> strategy:
> fail-fast: false
> @@ -41,7 +41,7 @@ jobs:
> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
> - BUILDTYPE: Release
> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
> - name: Linux/x86_64 ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }}
> + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }}
> steps:
> - uses: actions/checkout@v2.3.4
> with:
> @@ -57,3 +57,40 @@ jobs:
> run: cmake --build . --parallel $(($(nproc) + 1))
> - name: test
> run: cmake --build . --parallel $(($(nproc) + 1)) --target test
> +
> + test-tarantool-debug-wo-GC64:
> + name: Tarantool Debug GC64:OFF
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: OFF
> + buildtype: Debug
> + host: ubuntu-20.04-self-hosted
> + revision: ${{ github.sha }}
> + test-tarantool-debug-w-GC64:
> + name: Tarantool Debug GC64:ON
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: ON
> + buildtype: Debug
> + host: ubuntu-20.04-self-hosted
> + revision: ${{ github.sha }}
> + test-tarantool-release-wo-GC64:
> + name: Tarantool Release GC64:OFF
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: OFF
> + buildtype: RelWithDebInfo
> + host: ubuntu-20.04-self-hosted
> + revision: ${{ github.sha }}
> + test-tarantool-release-w-GC64:
> + name: Tarantool Release GC64:ON
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: ON
> + buildtype: RelWithDebInfo
> + host: ubuntu-20.04-self-hosted
> + revision: ${{ github.sha }}
> diff --git a/.github/workflows/macos-m1.yml b/.github/workflows/macos-m1.yml
> index a38f70f7..d305e609 100644
> --- a/.github/workflows/macos-m1.yml
> +++ b/.github/workflows/macos-m1.yml
> @@ -1,4 +1,4 @@
> -name: "LuaJIT test workflow (macOS/m1)"
> +name: "macOS/m1 test workflow"
>
> on:
> push:
> @@ -34,7 +34,7 @@ env:
> ARCH: arch -arm64
>
> jobs:
> - test-macos-m1:
> + test-luajit:
> runs-on: macos-11-m1
> strategy:
> fail-fast: false
> @@ -45,7 +45,7 @@ jobs:
> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
> - BUILDTYPE: Release
> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
> - name: macOS/m1 ${{ matrix.BUILDTYPE }} GC64:ON
> + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:ON
> steps:
> - uses: actions/checkout@v2.3.4
> with:
> @@ -70,3 +70,22 @@ jobs:
> run: ${ARCH} cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1))
> - name: test
> run: ${ARCH} cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1)) --target test
> +
> + test-tarantool-debug-w-GC64:
> + name: Tarantool Debug GC64:ON
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: ON
> + buildtype: Debug
> + host: macos-11-m1
> + revision: ${{ github.sha }}
> + test-tarantool-release-w-GC64:
> + name: Tarantool Release GC64:ON
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: ON
> + buildtype: RelWithDebInfo
> + host: macos-11-m1
> + revision: ${{ github.sha }}
> diff --git a/.github/workflows/macos-x86_64.yml b/.github/workflows/macos-x86_64.yml
> index a7c2f4e3..fc28c683 100644
> --- a/.github/workflows/macos-x86_64.yml
> +++ b/.github/workflows/macos-x86_64.yml
> @@ -1,4 +1,4 @@
> -name: "LuaJIT test workflow (macOS/x86_64)"
> +name: "macOS/x86_64 test workflow"
>
> on:
> push:
> @@ -29,7 +29,7 @@ concurrency:
> cancel-in-progress: true
>
> jobs:
> - test-macos-x86_64:
> + test-luajit:
> runs-on: macos-11
> strategy:
> fail-fast: false
> @@ -41,7 +41,7 @@ jobs:
> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=Debug -DLUA_USE_ASSERT=ON -DLUA_USE_APICHECK=ON
> - BUILDTYPE: Release
> CMAKEFLAGS: -DCMAKE_BUILD_TYPE=RelWithDebInfo
> - name: macOS/x86_64 ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }}
> + name: LuaJIT ${{ matrix.BUILDTYPE }} GC64:${{ matrix.GC64 }}
> steps:
> - uses: actions/checkout@v2.3.4
> with:
> @@ -66,3 +66,40 @@ jobs:
> run: cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1))
> - name: test
> run: cmake --build . --parallel $(($(sysctl -n hw.ncpu) + 1)) --target test
> +
> + test-tarantool-debug-wo-GC64:
> + name: Tarantool Debug GC64:OFF
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: OFF
> + buildtype: Debug
> + host: macos-11
> + revision: ${{ github.sha }}
> + test-tarantool-debug-w-GC64:
> + name: Tarantool Debug GC64:ON
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: ON
> + buildtype: Debug
> + host: macos-11
> + revision: ${{ github.sha }}
> + test-tarantool-release-wo-GC64:
> + name: Tarantool Release GC64:OFF
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: OFF
> + buildtype: RelWithDebInfo
> + host: macos-11
> + revision: ${{ github.sha }}
> + test-tarantool-release-w-GC64:
> + name: Tarantool Release GC64:ON
> + needs: test-luajit
> + uses: tarantool/tarantool/.github/workflows/luajit-integration.yml@master
> + with:
> + GC64: ON
> + buildtype: RelWithDebInfo
> + host: macos-11
> + revision: ${{ github.sha }}
next prev parent reply other threads:[~2022-07-01 13:39 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 15:33 [Tarantool-patches] [PATCH luajit 0/3] Integration testing and tiny fixes in CI Igor Munkin via Tarantool-patches
2022-06-22 15:33 ` [Tarantool-patches] [PATCH luajit 1/3] ci: fix --parallel argument for MacOS runners Igor Munkin via Tarantool-patches
2022-06-23 8:19 ` Sergey Kaplun via Tarantool-patches
2022-06-29 22:17 ` Igor Munkin via Tarantool-patches
2022-07-01 13:12 ` Sergey Bronnikov via Tarantool-patches
2022-07-04 7:05 ` Igor Munkin via Tarantool-patches
2022-07-05 17:20 ` Sergey Bronnikov via Tarantool-patches
2022-07-05 21:25 ` Igor Munkin via Tarantool-patches
2022-06-22 15:33 ` [Tarantool-patches] [PATCH luajit 2/3] ci: remove GC64 matrix entries for ARM64 workflows Igor Munkin via Tarantool-patches
2022-06-23 8:29 ` Sergey Kaplun via Tarantool-patches
2022-06-29 22:17 ` Igor Munkin via Tarantool-patches
2022-07-01 13:21 ` Sergey Bronnikov via Tarantool-patches
2022-07-04 7:05 ` Igor Munkin via Tarantool-patches
2022-06-22 15:33 ` [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing Igor Munkin via Tarantool-patches
2022-06-23 8:45 ` Sergey Kaplun via Tarantool-patches
2022-06-29 22:17 ` Igor Munkin via Tarantool-patches
2022-07-04 10:24 ` Sergey Kaplun via Tarantool-patches
2022-07-01 13:39 ` Sergey Bronnikov via Tarantool-patches [this message]
2022-07-04 7:07 ` Igor Munkin via Tarantool-patches
2022-07-04 10:09 ` Sergey Bronnikov via Tarantool-patches
2022-07-13 10:09 ` [Tarantool-patches] [PATCH luajit 0/3] Integration testing and tiny fixes in CI Igor Munkin via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bee91a8-da04-5637-b0f3-181a83474061@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=imun@tarantool.org \
--cc=sergeyb@tarantool.org \
--cc=skaplun@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox