Tarantool development patches archive
 help / color / mirror / Atom feed
From: Sergey Bronnikov via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Igor Munkin <imun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org
Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing
Date: Mon, 4 Jul 2022 13:09:37 +0300	[thread overview]
Message-ID: <39af21d4-80e7-123f-2675-eb8b5584cc3c@tarantool.org> (raw)
In-Reply-To: <YsKRmrH6A/ahQmTO@tarantool.org>

Igor,

LGTM

On 04.07.2022 10:07, Igor Munkin wrote:
> Sergey,
>
> Thanks for your review!
>
> On 01.07.22, Sergey Bronnikov wrote:
>> LGTM (see my comments inline).
> Added your tag:
> | Reviewed-by: Sergey Bronnikov <sergeyb@tarantool.org>
>
> Anyway, I've answered your comment with no fixes provided, so I postpone
> the push until your explicit approvement.
>
>>
>> On 22.06.2022 18:33, Igor Munkin wrote:
>>> This patch introduces additional steps with Tarantool integration
>>> testing to all existing LuaJIT workflows. All steps invoke reusable
>>> workflow[1] from Tarantool repository for each matrix entry being set
>>> for particular LuaJIT workflow.
>>>
>>> [1]: https://github.com/tarantool/tarantool/blob/master/.github/workflows/luajit-integration.yml
>>>
>>> Signed-off-by: Igor Munkin <imun@tarantool.org>
>>> ---
>>>    .github/workflows/linux-aarch64.yml | 25 +++++++++++++++--
>>>    .github/workflows/linux-x86_64.yml  | 43 +++++++++++++++++++++++++++--
>>>    .github/workflows/macos-m1.yml      | 25 +++++++++++++++--
>>>    .github/workflows/macos-x86_64.yml  | 43 +++++++++++++++++++++++++++--
>>>    4 files changed, 124 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml
>>> index de360b12..293b572e 100644
>>> --- a/.github/workflows/linux-aarch64.yml
>>> +++ b/.github/workflows/linux-aarch64.yml
>>> @@ -1,4 +1,4 @@
>>> -name: "LuaJIT test workflow (Linux/aarch64)"
>>> +name: "Linux/aarch64 test workflow"
>>>    
>> Nit: seems changes here and below with renaming jobs are not related to
>> commit.
> Yes and no. I've added new steps, hence this becomes *not only* "LuaJIT
> test workflow". I can move this renaming to the separate commit but
> strongly doubt it worths. If it doesn't bother you a lot, I would
> proceed with the patch with no changes.
>

I'll not insist with it, sure, let's proceed.

>>>    on:
>>>      push:
> <snipped>
>

  reply	other threads:[~2022-07-04 10:09 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-22 15:33 [Tarantool-patches] [PATCH luajit 0/3] Integration testing and tiny fixes in CI Igor Munkin via Tarantool-patches
2022-06-22 15:33 ` [Tarantool-patches] [PATCH luajit 1/3] ci: fix --parallel argument for MacOS runners Igor Munkin via Tarantool-patches
2022-06-23  8:19   ` Sergey Kaplun via Tarantool-patches
2022-06-29 22:17     ` Igor Munkin via Tarantool-patches
2022-07-01 13:12   ` Sergey Bronnikov via Tarantool-patches
2022-07-04  7:05     ` Igor Munkin via Tarantool-patches
2022-07-05 17:20   ` Sergey Bronnikov via Tarantool-patches
2022-07-05 21:25     ` Igor Munkin via Tarantool-patches
2022-06-22 15:33 ` [Tarantool-patches] [PATCH luajit 2/3] ci: remove GC64 matrix entries for ARM64 workflows Igor Munkin via Tarantool-patches
2022-06-23  8:29   ` Sergey Kaplun via Tarantool-patches
2022-06-29 22:17     ` Igor Munkin via Tarantool-patches
2022-07-01 13:21   ` Sergey Bronnikov via Tarantool-patches
2022-07-04  7:05     ` Igor Munkin via Tarantool-patches
2022-06-22 15:33 ` [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing Igor Munkin via Tarantool-patches
2022-06-23  8:45   ` Sergey Kaplun via Tarantool-patches
2022-06-29 22:17     ` Igor Munkin via Tarantool-patches
2022-07-04 10:24       ` Sergey Kaplun via Tarantool-patches
2022-07-01 13:39   ` Sergey Bronnikov via Tarantool-patches
2022-07-04  7:07     ` Igor Munkin via Tarantool-patches
2022-07-04 10:09       ` Sergey Bronnikov via Tarantool-patches [this message]
2022-07-13 10:09 ` [Tarantool-patches] [PATCH luajit 0/3] Integration testing and tiny fixes in CI Igor Munkin via Tarantool-patches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39af21d4-80e7-123f-2675-eb8b5584cc3c@tarantool.org \
    --to=tarantool-patches@dev.tarantool.org \
    --cc=imun@tarantool.org \
    --cc=sergeyb@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox