From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 936756ECE3; Mon, 4 Jul 2022 13:09:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 936756ECE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1656929380; bh=XKPIHHuuaO0vJHgthFWjafcdPmCWzgzXHmP2/x7dpp4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uV0s7VsfpM4IlRKl+y2z+3PeHsqdC1+9Gu/v04r7rdVvZ6SMSXAQUIK3448rtif9J rO9eiC7svZODqt8+h6LVkC+aqVGhmvw5q888UVALYboEQClN9/idvbllPkRePbUjUO I1e+GKEzlse7rbMv5DLkjZ78++d48uYaqymBlEsM= Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 25E256ECE3 for ; Mon, 4 Jul 2022 13:09:39 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 25E256ECE3 Received: by smtp17.mail.ru with esmtpa (envelope-from ) id 1o8J1O-0007od-Eu; Mon, 04 Jul 2022 13:09:38 +0300 Message-ID: <39af21d4-80e7-123f-2675-eb8b5584cc3c@tarantool.org> Date: Mon, 4 Jul 2022 13:09:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: Igor Munkin References: <0b728799a1a9a03e008c249ed12ded71134c5bd9.1655911291.git.imun@tarantool.org> <6bee91a8-da04-5637-b0f3-181a83474061@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9AABED37AFFA51518A10862901CCE4FD519A2D010BEC2E928182A05F5380850404C228DA9ACA6FE27A63FDE039C568604ECDDC7E57FECA6E64FF548229A28096610A351F8F47755B0 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76042E2DB3E33BF2BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B23888C9749F3CAC8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D865BE4D0A4BDF590AD501CF7F0B6A8CC7117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8BECADA55FE5B58BB7A471835C12D1D977C4224003CC836476EB9C4185024447017B076A6E789B0E975F5C1EE8F4F765FC9E91713CAE1065203AA81AA40904B5D9CF19DD082D7633A078D18283394535A93AA81AA40904B5D98AA50765F7900637C2AD092FD2BBF3C9D81D268191BDAD3D698AB9A7B718F8C4D1B931868CE1C5781A620F70A64A45A98AA50765F79006372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89FB26E97DCB74E62526D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-8FC586DF: 6EFBBC1D9D64D975 X-C1DE0DAB: 9604B64F49C60606AD91A466A1DEF99B296C473AB1E14218C6CDE5D1141D2B1C34851A35DAC281A88EFEC151E713870758356D74517FFB8AAD91A466A1DEF99B296C473AB1E14218B936CB490224F2464EEA7BD89490CAC0EDDA962BC3F61961 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34087368DEEB028F17BE4D640AC0353CA146716FE57CB2FBBA9A1C7368D3718C8531D664BA11DF80EF1D7E09C32AA3244C3F63739E9A2BA2CDEB515F15D1680BE38A6D4CC6FBFAC251FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoR2RQGvSEnQfqs0GcvQTgg== X-Mailru-Sender: 0A26D9779F8DDEAB424BEF630997B8BDEB09397AB62FD88F632F5C899C5DC0359CDC8A1A2A736FC6282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 3/3] ci: add Tarantool integration testing X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Igor, LGTM On 04.07.2022 10:07, Igor Munkin wrote: > Sergey, > > Thanks for your review! > > On 01.07.22, Sergey Bronnikov wrote: >> LGTM (see my comments inline). > Added your tag: > | Reviewed-by: Sergey Bronnikov > > Anyway, I've answered your comment with no fixes provided, so I postpone > the push until your explicit approvement. > >> >> On 22.06.2022 18:33, Igor Munkin wrote: >>> This patch introduces additional steps with Tarantool integration >>> testing to all existing LuaJIT workflows. All steps invoke reusable >>> workflow[1] from Tarantool repository for each matrix entry being set >>> for particular LuaJIT workflow. >>> >>> [1]: https://github.com/tarantool/tarantool/blob/master/.github/workflows/luajit-integration.yml >>> >>> Signed-off-by: Igor Munkin >>> --- >>> .github/workflows/linux-aarch64.yml | 25 +++++++++++++++-- >>> .github/workflows/linux-x86_64.yml | 43 +++++++++++++++++++++++++++-- >>> .github/workflows/macos-m1.yml | 25 +++++++++++++++-- >>> .github/workflows/macos-x86_64.yml | 43 +++++++++++++++++++++++++++-- >>> 4 files changed, 124 insertions(+), 12 deletions(-) >>> >>> diff --git a/.github/workflows/linux-aarch64.yml b/.github/workflows/linux-aarch64.yml >>> index de360b12..293b572e 100644 >>> --- a/.github/workflows/linux-aarch64.yml >>> +++ b/.github/workflows/linux-aarch64.yml >>> @@ -1,4 +1,4 @@ >>> -name: "LuaJIT test workflow (Linux/aarch64)" >>> +name: "Linux/aarch64 test workflow" >>> >> Nit: seems changes here and below with renaming jobs are not related to >> commit. > Yes and no. I've added new steps, hence this becomes *not only* "LuaJIT > test workflow". I can move this renaming to the separate commit but > strongly doubt it worths. If it doesn't bother you a lot, I would > proceed with the patch with no changes. > I'll not insist with it, sure, let's proceed. >>> on: >>> push: > >